Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Redshift parameters not rendering #14888

Merged
merged 4 commits into from
May 28, 2021
Merged

Conversation

hughhhh
Copy link
Member

@hughhhh hughhhh commented May 27, 2021

SUMMARY

Redshift's BasicMixinParams weren't rendering since we were missing a default driver reference

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

  • Has associated issue:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@codecov
Copy link

codecov bot commented May 27, 2021

Codecov Report

Merging #14888 (3fc628c) into master (2313e3e) will decrease coverage by 0.25%.
The diff coverage is 56.58%.

❗ Current head 3fc628c differs from pull request most recent head a56f766. Consider uploading reports for the commit a56f766 to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master   #14888      +/-   ##
==========================================
- Coverage   77.61%   77.35%   -0.26%     
==========================================
  Files         963      963              
  Lines       49264    49307      +43     
  Branches     6205     6226      +21     
==========================================
- Hits        38235    38141      -94     
- Misses      10828    10965     +137     
  Partials      201      201              
Flag Coverage Δ
hive ?
mysql 81.63% <100.00%> (+<0.01%) ⬆️
postgres 81.66% <100.00%> (+<0.01%) ⬆️
presto ?
python 81.74% <100.00%> (-0.44%) ⬇️
sqlite 81.27% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
superset-frontend/src/components/Form/FormItem.tsx 100.00% <ø> (ø)
...eFilters/FiltersConfigModal/FiltersConfigModal.tsx 95.18% <ø> (ø)
...mponents/nativeFilters/FiltersConfigModal/utils.ts 67.94% <ø> (ø)
...nd/src/dashboard/containers/DashboardComponent.jsx 84.84% <ø> (ø)
.../src/explore/components/ControlPanelsContainer.tsx 79.16% <0.00%> (-1.69%) ⬇️
.../src/explore/components/controls/SelectControl.jsx 89.38% <ø> (ø)
...rontend/src/visualizations/FilterBox/FilterBox.jsx 56.60% <0.00%> (-0.73%) ⬇️
...d/src/dashboard/components/gridComponents/Tabs.jsx 76.31% <21.05%> (-11.06%) ⬇️
...src/dashboard/components/FiltersBadge/selectors.ts 75.70% <50.00%> (-1.00%) ⬇️
...onfigModal/FiltersConfigForm/FiltersConfigForm.tsx 69.16% <61.17%> (+0.79%) ⬆️
... and 12 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2313e3e...a56f766. Read the comment docs.

@hughhhh hughhhh merged commit 8f81fc0 into master May 28, 2021
cccs-RyanS pushed a commit to CybercentreCanada/superset that referenced this pull request Dec 17, 2021
* Update redshift.py

* Update api_tests.py

* fixed test

* add file back
QAlexBall pushed a commit to QAlexBall/superset that referenced this pull request Dec 29, 2021
* Update redshift.py

* Update api_tests.py

* fixed test

* add file back
@rusackas rusackas deleted the db-connection-ui-redshift-fix branch January 30, 2023 19:21
cccs-rc pushed a commit to CybercentreCanada/superset that referenced this pull request Mar 6, 2024
* Update redshift.py

* Update api_tests.py

* fixed test

* add file back
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 1.3.0 labels Mar 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/M 🚢 1.3.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants