fix: time range in filter box error #14890
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
this PR is an urgent fix for regression introduced by #14841. Before #14841, when multiple select checkbox is unchecked in filterbox, selected filter value can not pass through query and trigger chart render on dashboard. Unfortunately, this PR introduced a regression that when there's time range filter in the filterbox, time filter value as STRING gets converted into array. This change doesn't affect any other control in the filterbox.
This PR is a fix forward of #14841, and will resolve both the original issue #14804 and the regression mentioned above.
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
Before
before-filter.mp4
After
May-28-2021.10-25-37.mp4
TESTING INSTRUCTIONS
ADDITIONAL INFORMATION