Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: time range in filter box error #14890

Merged
merged 1 commit into from
May 28, 2021

Conversation

zhaoyongjie
Copy link
Member

@zhaoyongjie zhaoyongjie commented May 28, 2021

SUMMARY

this PR is an urgent fix for regression introduced by #14841. Before #14841, when multiple select checkbox is unchecked in filterbox, selected filter value can not pass through query and trigger chart render on dashboard. Unfortunately, this PR introduced a regression that when there's time range filter in the filterbox, time filter value as STRING gets converted into array. This change doesn't affect any other control in the filterbox.

This PR is a fix forward of #14841, and will resolve both the original issue #14804 and the regression mentioned above.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

Before

before-filter.mp4

After

May-28-2021.10-25-37.mp4

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

  • Has associated issue:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@codecov
Copy link

codecov bot commented May 28, 2021

Codecov Report

Merging #14890 (4e9302b) into master (2313e3e) will decrease coverage by 0.00%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #14890      +/-   ##
==========================================
- Coverage   77.61%   77.60%   -0.01%     
==========================================
  Files         963      963              
  Lines       49264    49266       +2     
  Branches     6205     6207       +2     
==========================================
  Hits        38235    38235              
- Misses      10828    10830       +2     
  Partials      201      201              
Flag Coverage Δ
javascript 72.43% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...rontend/src/visualizations/FilterBox/FilterBox.jsx 56.60% <0.00%> (-0.73%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2313e3e...4e9302b. Read the comment docs.

@zhaoyongjie zhaoyongjie merged commit acbbced into apache:master May 28, 2021
@junlincc
Copy link
Member

junlincc commented May 28, 2021

@nytai many thanks for your quick review 🙏!!

@junlincc junlincc added viz:charts:filterbox Related to the Filterbox viz type rush! Requires immediate attention #bug:blocking! Blocking issues with high priority labels Jun 1, 2021
henryyeh pushed a commit to preset-io/superset that referenced this pull request Jun 1, 2021
cccs-RyanS pushed a commit to CybercentreCanada/superset that referenced this pull request Dec 17, 2021
QAlexBall pushed a commit to QAlexBall/superset that referenced this pull request Dec 29, 2021
cccs-rc pushed a commit to CybercentreCanada/superset that referenced this pull request Mar 6, 2024
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 1.3.0 labels Mar 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels #bug:blocking! Blocking issues with high priority rush! Requires immediate attention size/XS viz:charts:filterbox Related to the Filterbox viz type 🚢 1.3.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants