chore: customize adhoc filter icon and fix creatable label #14896
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #14896 +/- ##
==========================================
- Coverage 77.51% 77.39% -0.12%
==========================================
Files 963 963
Lines 49315 49316 +1
Branches 6226 6228 +2
==========================================
- Hits 38225 38167 -58
- Misses 10889 10950 +61
+ Partials 201 199 -2
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
michael-s-molina
requested changes
May 28, 2021
...c/explore/components/controls/FilterControl/AdhocFilterEditPopoverSimpleTabContent/index.jsx
Outdated
Show resolved
Hide resolved
| @@ -417,6 +418,9 @@ export default class AdhocFilterEditPopoverSimpleTabContent extends React.Compon | |||
| onSearch={val => this.setState({ currentSuggestionSearch: val })} | |||
| onSelect={this.clearSuggestionSearch} | |||
| onBlur={this.clearSuggestionSearch} | |||
| menuItemSelectedIcon={ | |||
| operator === 'NOT IN' ? <StopOutlined /> : <CheckOutlined /> | |||
There was a problem hiding this comment.
<Icons.StopOutlined> and <Icons.CheckOutlined>
villebro
force-pushed
the
villebro/select-polish
branch
from
77f7249
to
b52b425
Compare
villebro
force-pushed
the
villebro/select-polish
branch
from
b52b425
to
530919c
Compare
michael-s-molina
approved these changes
May 28, 2021
simcha90
reviewed
May 31, 2021
| <Icons.StopOutlined iconSize="m" /> | ||
| ) : ( | ||
| <Icons.CheckOutlined iconSize="m" /> | ||
| ) |
There was a problem hiding this comment.
May be shorter will be and also without duplication :)
const Icon = inverseSelection ? Icons.StopOutlined : Icons.CheckOutlined
...
menuItemSelectedIcon={<Icon iconSize="m" />}
simcha90
approved these changes
May 31, 2021
villebro
force-pushed
the
villebro/select-polish
branch
from
530919c
to
8a5eff4
Compare
cccs-RyanS
pushed a commit
to CybercentreCanada/superset
that referenced
this pull request
Dec 17, 2021
mistercrunch
added
🏷️ bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Harmonize AntD Select components that are used in Explore/Dashboard view. This changes the following:
StopOutlineIcon if "NOT IN" operator is selected. This is to align the behavior with the native select filter polish introduced in feat(native-filters): improve inverse selection indicators #14873react-selectbased component used in Filter Box:BEFORE
When "NOT IN" is selected in the adhoc filter popover, we currently use the default
CheckOutlinedicon:When being presented with the option to create a value that doesn't exist in the dataset, the option to use a value that doesn't exist is shown as-is:
AFTER
When "NOT IN" is selected in the adhoc filter popover, we now use the
StopOutlinedWhen being presented with the option to create a value that doesn't exist in the dataset, The creatable value is prefixed with "Create" and the value placed inside quotes:
TESTING INSTRUCTIONS
ADDITIONAL INFORMATION