fix: Remove Icon and align close button on DatasetModal #14902
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AAfghahi
force-pushed
the
ch15973_DatabaseModalCloseIcon
branch
from
b04f065
to
6109cfb
Compare
Codecov Report
@@ Coverage Diff @@
## master #14902 +/- ##
==========================================
+ Coverage 77.50% 77.54% +0.03%
==========================================
Files 963 963
Lines 49306 49304 -2
Branches 6226 6228 +2
==========================================
+ Hits 38216 38232 +16
+ Misses 10889 10873 -16
+ Partials 201 199 -2
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
betodealmeida
approved these changes
May 28, 2021
geido
reviewed
May 29, 2021
| {t('Add dataset')} | ||
| </> | ||
| } | ||
| title={<>{t('Add dataset')}</>} |
There was a problem hiding this comment.
Is the fragment needed here? Can't we just pass a plain string for the title?
There was a problem hiding this comment.
oh you know @geido , they don't need to be a fragment. Just passed in a regular string. Thank you!
cccs-RyanS
pushed a commit
to CybercentreCanada/superset
that referenced
this pull request
Dec 17, 2021
* aligned DatabaseModal header * revisions
QAlexBall
pushed a commit
to QAlexBall/superset
that referenced
this pull request
Dec 29, 2021
* aligned DatabaseModal header * revisions
cccs-rc
pushed a commit
to CybercentreCanada/superset
that referenced
this pull request
Mar 6, 2024
* aligned DatabaseModal header * revisions
mistercrunch
added
🏷️ bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
The Dataset Modal had a ! icon that didn't make sense and was causing the header to be misaligned. This removes that, which aligns everything.
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
Before:
After:
TESTING INSTRUCTIONS
Go to Datasets
Add a dataset
ADDITIONAL INFORMATION