Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Add Slovenian (sl_SI) translation #14908

Merged
merged 2 commits into from Jun 27, 2021
Merged

chore: Add Slovenian (sl_SI) translation #14908

merged 2 commits into from Jun 27, 2021

Conversation

dkrat7
Copy link
Contributor

@dkrat7 dkrat7 commented May 28, 2021

SUMMARY

New translation for superset UI is added - Slovenian (sl_SI).
I also extracted strings from the superset-ui repos and manually added some strings which are not extracted by the "pybabel extract".

P.S.
This is revision of my previous PR ( #13558 ), which was closed by me. There was an issue with wrong language code (si -> sl) and translations were outdated (this translation fits latest Superset state).

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

110685658-cd2e0480-81de-11eb-8913-9ed147fa0312

TESTING INSTRUCTIONS

Change language, inspect translations.

ADDITIONAL INFORMATION

  • Has associated issue:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

Copy link
Member

@eschutho eschutho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.. thank you!

@eschutho
Copy link
Member

eschutho commented Jun 2, 2021

@betodealmeida do you want to review as well?

@betodealmeida
Copy link
Member

Looks good to me as well!

@codecov
Copy link

codecov bot commented Jun 3, 2021

Codecov Report

Merging #14908 (9e6ae6c) into master (0eb34be) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #14908   +/-   ##
=======================================
  Coverage   77.59%   77.59%           
=======================================
  Files         963      963           
  Lines       49307    49307           
  Branches     6226     6226           
=======================================
  Hits        38258    38258           
  Misses      10848    10848           
  Partials      201      201           
Flag Coverage Δ
hive 81.35% <ø> (ø)
mysql 81.63% <ø> (ø)
postgres 81.66% <ø> (ø)
presto 81.35% <ø> (ø)
python 82.18% <ø> (ø)
sqlite 81.27% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
superset/config.py 91.09% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0eb34be...9e6ae6c. Read the comment docs.

@amitmiran137 amitmiran137 merged commit e62cb2f into apache:master Jun 27, 2021
mvoitko pushed a commit to mvoitko/superset that referenced this pull request Jun 28, 2021
* slovenian translation - config file

* slovenian translation - po, json
cccs-RyanS pushed a commit to CybercentreCanada/superset that referenced this pull request Dec 17, 2021
* slovenian translation - config file

* slovenian translation - po, json
QAlexBall pushed a commit to QAlexBall/superset that referenced this pull request Dec 29, 2021
* slovenian translation - config file

* slovenian translation - po, json
cccs-rc pushed a commit to CybercentreCanada/superset that referenced this pull request Mar 6, 2024
* slovenian translation - config file

* slovenian translation - po, json
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 1.3.0 labels Mar 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 1.3.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants