feat: Add service account #14917
Closed
feat: Add service account #14917
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
craig-rueda
requested changes
Jun 1, 2021
| @@ -53,6 +53,9 @@ spec: | |||
| app: {{ template "superset.name" . }}-worker | |||
| release: {{ .Release.Name }} | |||
| spec: | |||
| {{- if .Values.serviceAccount.create }} | |||
There was a problem hiding this comment.
Instead of guarding this with .Values.serviceAccount.create, we should define the name of the SA to use in values (default of empty, or null) and then use the SA name in this condition.
There was a problem hiding this comment.
I have done exactly this in my PR. Please review.
| @@ -56,6 +56,9 @@ spec: | |||
| app: {{ template "superset.name" . }} | |||
| release: {{ .Release.Name }} | |||
| spec: | |||
| {{- if .Values.serviceAccount.create }} | |||
| serviceAccountName: {{ template "superset.name" . }} | |||
| {{- end }} | |||
| apiVersion: v1 | ||
| kind: ServiceAccount | ||
| metadata: | ||
| name: {{ template "superset.name" . }} |
There was a problem hiding this comment.
For the SA name, we should allow the user to customize via values.yaml
mvoitko
reviewed
Jun 23, 2021
| # See the License for the specific language governing permissions and | ||
| # limitations under the License. | ||
| # | ||
| apiVersion: v1 |
There was a problem hiding this comment.
Should Superset chart create Service Account? I suggest we simplify and assume that a user will create a SA with needed permissions. It may be done in several ways. For example it's more common to create IRSA in AWS with Terraform.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
I am adding this chart to my gke cluster, and I don't like the concept of adding my gcp service account secrets to a k8s secret and I plan to mount my service-account to the k8s service account as a workload