Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(native-filters): add test for Select filter #14919

Merged
merged 12 commits into from
May 31, 2021
Merged

Conversation

simcha90
Copy link
Contributor

@simcha90 simcha90 commented May 30, 2021

SUMMARY

Add tests for Select filter.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

  • Has associated issue:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@simcha90 simcha90 changed the title tests(native-filters): add test for Select filter test(native-filters): add test for Select filter May 30, 2021
@codecov
Copy link

codecov bot commented May 30, 2021

Codecov Report

Merging #14919 (01e1b54) into master (51935dd) will increase coverage by 0.03%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #14919      +/-   ##
==========================================
+ Coverage   77.59%   77.62%   +0.03%     
==========================================
  Files         963      963              
  Lines       49315    49315              
  Branches     6226     6226              
==========================================
+ Hits        38266    38281      +15     
+ Misses      10848    10834      -14     
+ Partials      201      200       -1     
Flag Coverage Δ
javascript 72.45% <ø> (+0.06%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...c/filters/components/Select/SelectFilterPlugin.tsx 81.52% <0.00%> (+11.95%) ⬆️
...nd/src/filters/components/Select/transformProps.ts 100.00% <0.00%> (+28.57%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 51935dd...01e1b54. Read the comment docs.

@villebro villebro merged commit 50c5dcb into apache:master May 31, 2021
cccs-RyanS pushed a commit to CybercentreCanada/superset that referenced this pull request Dec 17, 2021
* fix:fix get permission function

* test: tests for select filter
QAlexBall pushed a commit to QAlexBall/superset that referenced this pull request Dec 29, 2021
* fix:fix get permission function

* test: tests for select filter
cccs-rc pushed a commit to CybercentreCanada/superset that referenced this pull request Mar 6, 2024
* fix:fix get permission function

* test: tests for select filter
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 1.3.0 labels Mar 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/L 🚢 1.3.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants