Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build(webpack): use [contenthash] instead of [chunkhash] #14942

Merged
merged 2 commits into from
Jun 9, 2021

Conversation

nytai
Copy link
Member

@nytai nytai commented Jun 2, 2021

SUMMARY

Webpack's chunkhash is not reliable and produces different hashes for builds of the same assets. Using contenthash is far more reliable for caching dependencies based on content.

More info available in this issue webpack/webpack#7179

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

N/A

TESTING INSTRUCTIONS

  • npm run build produces a working prod build

ADDITIONAL INFORMATION

  • Has associated issue:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@codecov
Copy link

codecov bot commented Jun 2, 2021

Codecov Report

Merging #14942 (5be1e18) into master (8cc97e4) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #14942   +/-   ##
=======================================
  Coverage   77.57%   77.57%           
=======================================
  Files         964      964           
  Lines       49385    49385           
  Branches     6238     6238           
=======================================
  Hits        38310    38310           
  Misses      10874    10874           
  Partials      201      201           
Flag Coverage Δ
javascript 72.36% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8cc97e4...5be1e18. Read the comment docs.

@pull-request-size pull-request-size bot added size/S and removed size/XS labels Jun 2, 2021
@nytai nytai changed the title fix(webpack): use [contenthash] instead of [chunkhash] build(webpack): use [contenthash] instead of [chunkhash] Jun 2, 2021
@nytai nytai requested review from ktmud, rusackas and suddjian June 3, 2021 03:30
@nytai nytai merged commit 821519f into apache:master Jun 9, 2021
@nytai nytai deleted the tai/fix-webpack-hash branch June 9, 2021 19:59
etr2460 pushed a commit that referenced this pull request Jun 21, 2021
etr2460 pushed a commit to airbnb/superset-fork that referenced this pull request Jun 21, 2021
serenajiang pushed a commit that referenced this pull request Jun 23, 2021
cccs-RyanS pushed a commit to CybercentreCanada/superset that referenced this pull request Dec 17, 2021
cccs-RyanS pushed a commit to CybercentreCanada/superset that referenced this pull request Dec 17, 2021
QAlexBall pushed a commit to QAlexBall/superset that referenced this pull request Dec 29, 2021
QAlexBall pushed a commit to QAlexBall/superset that referenced this pull request Dec 29, 2021
cccs-rc pushed a commit to CybercentreCanada/superset that referenced this pull request Mar 6, 2024
cccs-rc pushed a commit to CybercentreCanada/superset that referenced this pull request Mar 6, 2024
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 1.3.0 labels Mar 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels preset-io size/S 🚢 1.3.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants