-
Notifications
You must be signed in to change notification settings - Fork 13.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
build(webpack): use [contenthash] instead of [chunkhash] #14942
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #14942 +/- ##
=======================================
Coverage 77.57% 77.57%
=======================================
Files 964 964
Lines 49385 49385
Branches 6238 6238
=======================================
Hits 38310 38310
Misses 10874 10874
Partials 201 201
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report at Codecov.
|
suddjian
approved these changes
Jun 9, 2021
etr2460
pushed a commit
that referenced
this pull request
Jun 21, 2021
)" This reverts commit 821519f.
etr2460
pushed a commit
to airbnb/superset-fork
that referenced
this pull request
Jun 21, 2021
…che#14942)" This reverts commit 821519f.
cccs-RyanS
pushed a commit
to CybercentreCanada/superset
that referenced
this pull request
Dec 17, 2021
cccs-RyanS
pushed a commit
to CybercentreCanada/superset
that referenced
this pull request
Dec 17, 2021
…che#14942)" (apache#15285) This reverts commit 821519f.
QAlexBall
pushed a commit
to QAlexBall/superset
that referenced
this pull request
Dec 29, 2021
QAlexBall
pushed a commit
to QAlexBall/superset
that referenced
this pull request
Dec 29, 2021
…che#14942)" (apache#15285) This reverts commit 821519f.
cccs-rc
pushed a commit
to CybercentreCanada/superset
that referenced
this pull request
Mar 6, 2024
cccs-rc
pushed a commit
to CybercentreCanada/superset
that referenced
this pull request
Mar 6, 2024
…che#14942)" (apache#15285) This reverts commit b10f0c9.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Webpack's
chunkhash
is not reliable and produces different hashes for builds of the same assets. Usingcontenthash
is far more reliable for caching dependencies based on content.More info available in this issue webpack/webpack#7179
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
N/A
TESTING INSTRUCTIONS
npm run build
produces a working prod buildADDITIONAL INFORMATION