fix(datasets): consistent dataset list

[zhaoyongjie]

SUMMARY

closes: #14262

Currently, between the Dataset list view and change dataset modal datasets order is inconsistent. The change dataset modal can not display all datasets.

This PR make

1. Dataset list view and change dataset modal datasets order is consistent
2. make server pagination in change dataset modal
3. All datasets can be displayed in change dataset modal
4. backend sort by in change dataset modal
5. use owners replace creator

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

Before

After

Consistent dataset list between dataset list and Change dataset modal

Jun-08-2021.20-30-14.mp4

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

• Has associated issue: [Chart edition][Dataset][Search] The list of available datasets is incomplete #14262
• Changes UI
• Includes DB Migration (follow approval process in SIP-59)
  • Migration is atomic, supports rollback & is backwards-compatible
  • Confirm DB migration upgrade and downgrade tested
  • Runtime estimates and downtime expectations provided
• Introduces new feature or API
• Removes existing feature or API

[junlincc]

/testenv up

[github-actions]

@junlincc Ephemeral environment spinning up at http://54.245.30.41:8080. Credentials are admin/admin. Please allow several minutes for bootstrapping and startup.

[junlincc]

😞thanks for the PR.

1. after the PR, sorting no longer work~ :( please make sure when we add new feature, the old related behavior is preserved.
2. not related to this PR, please have pagination fixed at the bottom on scroll.

Screen.Recording.2021-06-07.at.11.56.02.AM.mov

[zhaoyongjie]

@junlincc

1. The frontend sorting seems that not work previous. the after screenshot is on the master branch. let me try to fix it.

2. the pagination flowing, I will fix it in separate PR.

[zhaoyongjie]

/testenv up

[github-actions]

@zhaoyongjie Ephemeral environment creation is currently limited to committers.

[codecov]

Codecov Report

Merging #15014 (544731c) into master (0e07a5c) will increase coverage by 0.00%.
The diff coverage is 82.85%.

@@           Coverage Diff           @@
##           master   #15014   +/-   ##
=======================================
  Coverage   77.64%   77.64%           
=======================================
  Files         966      967    +1     
  Lines       49615    49643   +28     
  Branches     6311     6324   +13     
=======================================
+ Hits        38524    38547   +23     
- Misses      10890    10895    +5     
  Partials      201      201           

Flag	Coverage Δ
javascript	72.79% <82.85%> (+0.01%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
...-frontend/src/datasource/ChangeDatasourceModal.tsx	87.35% <76.47%> (-3.56%)	⬇️
...et-frontend/src/components/TableView/TableView.tsx	96.96% <81.81%> (-1.25%)	⬇️
...ontend/src/views/CRUD/data/dataset/DatasetList.tsx	70.18% <100.00%> (-0.37%)	⬇️
...-frontend/src/views/CRUD/data/dataset/constants.ts	100.00% <100.00%> (ø)
...-frontend/src/explore/components/ControlHeader.jsx	85.71% <0.00%> (ø)
...ConfigModal/FiltersConfigForm/FilterScope/utils.ts	98.50% <0.00%> (+0.06%)	⬆️
...d/components/DashboardBuilder/DashboardBuilder.tsx	91.02% <0.00%> (+0.11%)	⬆️
...d/src/dashboard/components/gridComponents/Tabs.jsx	87.50% <0.00%> (+0.12%)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0e07a5c...544731c. Read the comment docs.

[junlincc]

/testenv up

[github-actions]

@junlincc Ephemeral environment spinning up at http://52.34.217.130:8080. Credentials are admin/admin. Please allow several minutes for bootstrapping and startup.

[junlincc]

@zhaoyongjie thanks for addressing the issues! Pagination is 'fixed' and Sort works mostly as expected! 🙏
only thing I'm not sure is the cap F goes to the top of the list.
I spot checked pagination in other areas, list view, data south table, they all look good!

Screen.Recording.2021-06-08.at.11.38.44.AM.mov

[zhaoyongjie]

@zhaoyongjie thanks for addressing the issues! Pagination is 'fixed' and Sort works mostly as expected! 🙏
only thing I'm not sure is the cap F goes to the top of the list.
I spot checked pagination in other areas, list view, data south table, they all look good!
Screen.Recording.2021-06-08.at.11.38.44.AM.mov

Due to server sorting, it's order is ASCII order. refer to:

• https://support.ecisolutions.com/doc-ddms/help/reportsmenu/ascii_sort_order_chart.htm
• https://en.wikipedia.org/wiki/ASCII#Character_order

[villebro]

This is really great work! Code LGTM; I tested all affected areas as best as I could and couldn't find any regressions. The sort problem @junlincc identified is indeed confusing, but I assume that's down to the backend database collation, so needs to be fixed elsewhere.

[junlincc]

product sign-off. remaining sorting known issue will be addressed in follow-up PRs.

[github-actions]

Ephemeral environment shutdown and build artifacts deleted.