fix(native-filters): remove hard-coded default time range

[villebro]

SUMMARY

Currently the time range native filter defaults to "Last week" despite the new default being "No Filter" as introduced in #14661. This PR removes all references to "Last week" and leaves the time range value unset unless explicitly set. Other changes:

• remove local state and replace with filterState (which the application has control over)
• remove references to defaultValue (this is now fully handled by the application)

BEFORE

When leaving the default value unset, the value shows up as "Last week":

AFTER

Now it defaults to "No filter":

When no filter is defined, the filter indicator shows the filter as being unset:

TESTING INSTRUCTIONS

Local testing:

• Tried setting and leaving filter unset
• Click "Clear all" button - resets to "No filter"
• Set filter and click "Apply" and see that time filter applies properly

ADDITIONAL INFORMATION

• Has associated issue: closes [native-filters]"No filter" state in wrong section of filter indicator #15027
• Changes UI
• Includes DB Migration (follow approval process in SIP-59)
  • Migration is atomic, supports rollback & is backwards-compatible
  • Confirm DB migration upgrade and downgrade tested
  • Runtime estimates and downtime expectations provided
• Introduces new feature or API
• Removes existing feature or API

[junlincc]

/testenv up FEATURE_DASHBOARD_NATIVE_FILTERS=true

[github-actions]

@junlincc Ephemeral environment spinning up at http://35.163.111.252:8080. Credentials are admin/admin. Please allow several minutes for bootstrapping and startup.

[junlincc]

@villebro thanks for the PR! looks like hard coded time range are removed, but filter is not affecting the query. please see video, when i do set time range to last week, dashboard has no change.

Screen.Recording.2021-06-08.at.11.32.17.AM.mov

[villebro]

@villebro thanks for the PR! looks like hard coded time range are removed, but filter is not affecting the query. please see video, when i do set time range to last week, dashboard has no change.

Screen.Recording.2021-06-08.at.11.32.17.AM.mov

😱 Thanks for testing - will look into this asap and add a test.

[villebro]

@junlincc it's applying fine for me:

It appears that the COVID dataset doesn't have a temporal column. Which raises the question, we should probably not show a time filter (or time column filter for that matter) if there are no temporal columns available in the target dataset. However, this same problem applies to Filter Box as well, so I propose leaving that to a later PR.

[junlincc]

sounds good. does #15068 make sense? cc @kgabryje @michael-s-molina

[junlincc]

thanks again for the fix! product sign-off ✅ @rusackas ready for ya

[zhaoyongjie]

Nice, LGTM.

Notice that this default behavior may produce some slow queries for some database(missing time partition column)

[github-actions]

Ephemeral environment shutdown and build artifacts deleted.

[rosemarie-chiu]

🏷2021.23