Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Adds left padding to dashboard edit mode when filter bar is closed #15024

Merged
merged 1 commit into from Jun 8, 2021
Merged

fix: Adds left padding to dashboard edit mode when filter bar is closed #15024

merged 1 commit into from Jun 8, 2021

Conversation

michael-s-molina
Copy link
Member

@michael-s-molina michael-s-molina commented Jun 7, 2021 •
edited by villebro

SUMMARY

Fixes #14992, fixes #14728

@junlincc @rusackas

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

120843807-655c3100-c523-11eb-9c95-276974ee5a68.mov
screen-recording-2021-06-07-at-42717-pm_4Vt2lsJ9.mov

TESTING INSTRUCTIONS

See before/after videos.

ADDITIONAL INFORMATION

  • Has associated issue:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@junlincc junlincc added this to In progress in Native dashboard filters via automation Jun 7, 2021
@junlincc junlincc moved this from In progress to In review in Native dashboard filters Jun 7, 2021
villebro
villebro approved these changes Jun 8, 2021
View reviewed changes
Copy link
Member

@villebro villebro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@villebro villebro merged commit 1af91ed into apache:master Jun 8, 2021
Native dashboard filters automation moved this from In review to Done Jun 8, 2021
@junlincc junlincc added the dashboard:native-filters Related to the native filters of the Dashboard label Jun 10, 2021
cccs-RyanS pushed a commit to CybercentreCanada/superset that referenced this pull request Dec 17, 2021
@michael-s-molina
fix: Adds left padding to dashboard edit mode when filter bar is clos…
2cfc0e5 
…ed (apache#15024)
QAlexBall pushed a commit to QAlexBall/superset that referenced this pull request Dec 29, 2021
@michael-s-molina
fix: Adds left padding to dashboard edit mode when filter bar is clos…
7c8ba58 
…ed (apache#15024)
cccs-rc pushed a commit to CybercentreCanada/superset that referenced this pull request Mar 6, 2024
@michael-s-molina
fix: Adds left padding to dashboard edit mode when filter bar is clos…
8c329f6 
…ed (apache#15024)
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 1.3.0 labels Mar 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@villebro villebro villebro approved these changes

Assignees
No one assigned
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels dashboard:native-filters Related to the native filters of the Dashboard size/S 🚢 1.3.0
Projects
No open projects
Native dashboard filters
Done
Milestone
No milestone
4 participants
@michael-s-molina @villebro @mistercrunch @junlincc