Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(docs): update releasing docs #15040

Merged
merged 1 commit into from
Jun 20, 2021
Merged

Conversation

amitmiran137
Copy link
Member

SUMMARY

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

  • Has associated issue:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@codecov
Copy link

codecov bot commented Jun 8, 2021

Codecov Report

Merging #15040 (c35fc40) into master (1af91ed) will increase coverage by 0.29%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #15040      +/-   ##
==========================================
+ Coverage   77.31%   77.60%   +0.29%     
==========================================
  Files         966      966              
  Lines       49613    49615       +2     
  Branches     6311     6311              
==========================================
+ Hits        38356    38505     +149     
+ Misses      11056    10909     -147     
  Partials      201      201              
Flag Coverage Δ
hive ?
mysql 81.63% <ø> (?)
postgres 81.64% <ø> (?)
presto 81.34% <ø> (?)
python 81.92% <ø> (+0.56%) ⬆️
sqlite 81.27% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
superset/db_engines/hive.py 0.00% <0.00%> (-85.19%) ⬇️
superset/db_engine_specs/hive.py 70.32% <0.00%> (-17.08%) ⬇️
superset/utils/core.py 88.91% <0.00%> (+0.37%) ⬆️
superset/views/base_api.py 98.28% <0.00%> (+0.42%) ⬆️
superset/common/query_context.py 82.16% <0.00%> (+0.54%) ⬆️
superset/security/manager.py 91.57% <0.00%> (+0.54%) ⬆️
superset/utils/cache.py 74.25% <0.00%> (+0.99%) ⬆️
superset/db_engine_specs/postgres.py 96.96% <0.00%> (+1.01%) ⬆️
superset/connectors/sqla/models.py 89.57% <0.00%> (+1.42%) ⬆️
superset/db_engine_specs/mysql.py 94.28% <0.00%> (+1.42%) ⬆️
... and 15 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1af91ed...c35fc40. Read the comment docs.

Copy link
Member

@villebro villebro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing!

@amitmiran137 amitmiran137 merged commit a7f89b8 into master Jun 20, 2021
@amitmiran137 amitmiran137 deleted the amitmiran137-patch-2 branch June 20, 2021 16:35
cccs-RyanS pushed a commit to CybercentreCanada/superset that referenced this pull request Dec 17, 2021
QAlexBall pushed a commit to QAlexBall/superset that referenced this pull request Dec 29, 2021
cccs-rc pushed a commit to CybercentreCanada/superset that referenced this pull request Mar 6, 2024
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 1.3.0 labels Mar 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/XS 🚢 1.3.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants