feat(dashboard): Let users download full CSV of a table

[m-ajay]

SUMMARY

Lets user download the full CSV of a table.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

Manual and CI

ADDITIONAL INFORMATION

• Has associated issue:
• Changes UI
• Includes DB Migration (follow approval process in SIP-59)
  • Migration is atomic, supports rollback & is backwards-compatible
  • Confirm DB migration upgrade and downgrade tested
  • Runtime estimates and downtime expectations provided
• Introduces new feature or API
• Removes existing feature or API

[nytai]

Exporting a full CSV could cause the server to run out of memory and/or compute, how should this be handled? I think and ideal solution would be to stream the results down to the client, but that would be a significantly larger effort. Perhaps adding a config key to optionally enable this feature might be enough to mitigate this concern.

cc @betodealmeida

[junlincc]

thanks for the contribution! @rusackas this dropdown list is getting a bit long, we may need to restructure it a bit.

[etr2460]

Exporting a full CSV could cause the server to run out of memory and/or compute, how should this be handled? I think and ideal solution would be to stream the results down to the client, but that would be a significantly larger effort. Perhaps adding a config key to optionally enable this feature might be enough to mitigate this concern.

100% agree with the perf question, in this case i think a feature flag/config option would resolve this. Streaming results seems especially difficult to do with our current infra (maybe easier once async everywhere is ready for primetime). For context for our use case, we're ok with the performance issues and potential OOMs that this might introduce since everything is in k8s and autoscalable anyway.

[codecov]

Codecov Report

Merging #15046 (7482744) into master (cc2b4fe) will decrease coverage by 0.27%.
The diff coverage is 65.49%.

❗ Current head 7482744 differs from pull request most recent head 513274a. Consider uploading reports for the commit 513274a to get more accurate results

@@            Coverage Diff             @@
##           master   #15046      +/-   ##
==========================================
- Coverage   77.54%   77.26%   -0.28%     
==========================================
  Files         967      969       +2     
  Lines       49752    49918     +166     
  Branches     6351     6393      +42     
==========================================
- Hits        38578    38569       -9     
- Misses      10972    11146     +174     
- Partials      202      203       +1     

Flag	Coverage Δ
hive	?
mysql	81.71% <81.48%> (-0.01%)	⬇️
postgres	81.73% <81.48%> (-0.01%)	⬇️
python	81.82% <81.48%> (-0.30%)	⬇️
sqlite	81.35% <81.48%> (-0.01%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
superset-frontend/src/dashboard/actions/hydrate.js	1.72% <ø> (ø)
...ard/components/FiltersBadge/DetailsPanel/index.tsx	86.20% <ø> (ø)
.../FilterBar/CascadeFilters/CascadePopover/index.tsx	61.76% <ø> (ø)
...Filters/FilterBar/FilterControls/FilterControl.tsx	100.00% <ø> (ø)
...perset-frontend/src/dashboard/containers/Chart.jsx	100.00% <ø> (ø)
...nd/src/dashboard/containers/DashboardComponent.jsx	92.30% <ø> (ø)
...-frontend/src/dashboard/reducers/dashboardState.js	73.33% <0.00%> (ø)
...et-frontend/src/filters/components/Select/types.ts	100.00% <ø> (ø)
superset-frontend/src/views/CRUD/utils.tsx	63.86% <ø> (-1.26%)	⬇️
superset/config.py	91.15% <ø> (ø)
... and 54 more

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cc2b4fe...513274a. Read the comment docs.

[graceguo-supercat]

I have a little concern about too many configs in different places. Is possible to read this parameter from backend and carry it to frontend as part of bootstrap data. check this place:

superset/superset/views/base.py

Line 84 in cc2b4fe

FRONTEND_CONF_KEYS = (

[graceguo-supercat]

LGTM