Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: adopt --app as celery global option #15053

Merged
merged 1 commit into from
Jun 9, 2021
Merged

Conversation

shawnzhu
Copy link
Contributor

@shawnzhu shawnzhu commented Jun 9, 2021

SUMMARY

This is the step 1 of upgrading to Celery 5

Celery 5.0 introduces a new CLI implementation which isn’t completely backwards compatible.
The global options can no longer be positioned after the sub-command. Instead, they must be positioned as an option for the celery command like so:

celery --app path.to.app worker

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

@shawnzhu shawnzhu changed the title docs; adopt --app as celery global option docs: adopt --app as celery global option Jun 9, 2021
@shawnzhu shawnzhu mentioned this pull request Jun 9, 2021
12 tasks
@codecov
Copy link

codecov bot commented Jun 9, 2021

Codecov Report

Merging #15053 (decb90a) into master (3f527c7) will increase coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #15053      +/-   ##
==========================================
+ Coverage   77.76%   77.78%   +0.02%     
==========================================
  Files         966      966              
  Lines       49628    49628              
  Branches     6314     6314              
==========================================
+ Hits        38591    38604      +13     
+ Misses      10836    10823      -13     
  Partials      201      201              
Flag Coverage Δ
hive 81.43% <ø> (ø)
mysql 81.70% <ø> (ø)
postgres 81.72% <ø> (?)
presto 81.43% <ø> (+<0.01%) ⬆️
python 82.25% <ø> (+0.04%) ⬆️
sqlite 81.35% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
superset/db_engine_specs/presto.py 90.31% <0.00%> (+0.42%) ⬆️
superset/views/base_api.py 98.28% <0.00%> (+0.42%) ⬆️
superset/db_engine_specs/postgres.py 96.96% <0.00%> (+1.01%) ⬆️
superset/sql_validators/postgres.py 100.00% <0.00%> (+50.00%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3f527c7...decb90a. Read the comment docs.

@shawnzhu
Copy link
Contributor Author

shawnzhu commented Jun 9, 2021

I hope this PR will make review of #14926 (a downstream dependency) easier

@nytai nytai changed the title docs: adopt --app as celery global option refactor: adopt --app as celery global option Jun 9, 2021
@nytai
Copy link
Member

nytai commented Jun 9, 2021

@shawnzhu thanks for the contribution! Looks like this change is compatible with the current version of celery so happy to merge once CI passes. As for #14926, it will require more thorough testing of our celery dependant features as it is a significant change.

@nytai nytai merged commit 9967a5f into apache:master Jun 9, 2021
@shawnzhu shawnzhu deleted the doc branch June 9, 2021 12:41
@shawnzhu
Copy link
Contributor Author

shawnzhu commented Jun 9, 2021

@nytai Thanks for the feedback! Now i can get #14926 to pass CI after this is merged

cccs-RyanS pushed a commit to CybercentreCanada/superset that referenced this pull request Dec 17, 2021
QAlexBall pushed a commit to QAlexBall/superset that referenced this pull request Dec 29, 2021
cccs-rc pushed a commit to CybercentreCanada/superset that referenced this pull request Mar 6, 2024
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 1.3.0 labels Mar 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/M 🚢 1.3.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants