New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: stop using deprecated celery task API #15062
Conversation
Codecov Report
@@ Coverage Diff @@
## master #15062 +/- ##
==========================================
- Coverage 77.78% 77.53% -0.26%
==========================================
Files 966 966
Lines 49629 49629
Branches 6314 6314
==========================================
- Hits 38606 38479 -127
- Misses 10822 10949 +127
Partials 201 201
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
Thanks for the contribution, please get the last check pass, happy to get it thru if change makes sense. cc @zhaoyongjie @villebro |
We should also loop in @dpgaspar @robdiciuccio and @craig-rueda to see if there are any concerns with migrating to celery 5. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nick, LGTM.
SUMMARY
Replace deprecated celery task API (has been removed in Celery 5). see details from Removals for version 5.0 - Celery Deprecation Timeline
This is splitted from #14926
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
TESTING INSTRUCTIONS
ADDITIONAL INFORMATION