Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: stop using deprecated celery task API #15062

Merged
merged 1 commit into from Jun 10, 2021

Conversation

shawnzhu
Copy link
Contributor

@shawnzhu shawnzhu commented Jun 9, 2021

SUMMARY

Replace deprecated celery task API (has been removed in Celery 5). see details from Removals for version 5.0 - Celery Deprecation Timeline

This is splitted from #14926

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

@codecov
Copy link

codecov bot commented Jun 9, 2021

Codecov Report

Merging #15062 (f9b4173) into master (e82433e) will decrease coverage by 0.25%.
The diff coverage is 100.00%.

❗ Current head f9b4173 differs from pull request most recent head f88996f. Consider uploading reports for the commit f88996f to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master   #15062      +/-   ##
==========================================
- Coverage   77.78%   77.53%   -0.26%     
==========================================
  Files         966      966              
  Lines       49629    49629              
  Branches     6314     6314              
==========================================
- Hits        38606    38479     -127     
- Misses      10822    10949     +127     
  Partials      201      201              
Flag Coverage Δ
hive ?
mysql ?
postgres 81.73% <100.00%> (ø)
presto ?
python 81.77% <100.00%> (-0.49%) ⬇️
sqlite 81.35% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
superset/sql_lab.py 81.90% <100.00%> (ø)
superset/db_engines/hive.py 0.00% <0.00%> (-82.15%) ⬇️
superset/db_engine_specs/hive.py 70.32% <0.00%> (-17.08%) ⬇️
superset/db_engine_specs/presto.py 83.36% <0.00%> (-6.95%) ⬇️
superset/views/database/mixins.py 81.03% <0.00%> (-1.73%) ⬇️
superset/connectors/sqla/models.py 88.15% <0.00%> (-1.66%) ⬇️
superset/db_engine_specs/mysql.py 92.85% <0.00%> (-1.43%) ⬇️
superset/models/core.py 88.97% <0.00%> (-1.05%) ⬇️
superset/views/core.py 75.03% <0.00%> (-0.45%) ⬇️
superset/db_engine_specs/base.py 87.97% <0.00%> (-0.41%) ⬇️
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 821519f...f88996f. Read the comment docs.

@shawnzhu shawnzhu changed the title fix: stop using deprecated celery task API refactor: stop using deprecated celery task API Jun 9, 2021
@junlincc
Copy link
Member

junlincc commented Jun 9, 2021

Thanks for the contribution, please get the last check pass, happy to get it thru if change makes sense. cc @zhaoyongjie @villebro

@nytai
Copy link
Member

nytai commented Jun 9, 2021

We should also loop in @dpgaspar @robdiciuccio and @craig-rueda to see if there are any concerns with migrating to celery 5.

Copy link
Member

@craig-rueda craig-rueda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@zhaoyongjie zhaoyongjie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nick, LGTM.

@rusackas rusackas merged commit 31da394 into apache:master Jun 10, 2021
@shawnzhu shawnzhu deleted the celery-5 branch June 11, 2021 00:06
cccs-RyanS pushed a commit to CybercentreCanada/superset that referenced this pull request Dec 17, 2021
QAlexBall pushed a commit to QAlexBall/superset that referenced this pull request Dec 29, 2021
cccs-rc pushed a commit to CybercentreCanada/superset that referenced this pull request Mar 6, 2024
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 1.3.0 labels Mar 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/XS 🚢 1.3.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants