fix: move metric parsing to state instantiation #15069
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/testenv up |
|
@eschutho Ephemeral environment creation is currently limited to committers. |
|
/testenv up |
|
@hughhhh Ephemeral environment spinning up at http://54.212.72.236:8080. Credentials are |
hughhhh
approved these changes
Jun 9, 2021
Codecov Report
@@ Coverage Diff @@
## master #15069 +/- ##
=======================================
Coverage 77.78% 77.78%
=======================================
Files 966 966
Lines 49629 49629
Branches 6314 6314
=======================================
Hits 38604 38604
Misses 10824 10824
Partials 201 201
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
|
Ephemeral environment shutdown and build artifacts deleted. |
|
🏷 2021.23 |
henryyeh
pushed a commit
to preset-io/superset
that referenced
this pull request
Jun 15, 2021
(cherry picked from commit 0c470fe)
cccs-RyanS
pushed a commit
to CybercentreCanada/superset
that referenced
this pull request
Dec 17, 2021
QAlexBall
pushed a commit
to QAlexBall/superset
that referenced
this pull request
Dec 29, 2021
cccs-rc
pushed a commit
to CybercentreCanada/superset
that referenced
this pull request
Mar 6, 2024
mistercrunch
added
🏷️ bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
I noticed while testing that the markdown metric field isn't updating properly.
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
After:
dataset.mov
TESTING INSTRUCTIONS
It's difficult to write any kind of tests for the ace editor when looking at value because it always renders "xxx". Something we can try to figure out in the future. In the meantime I added more tests around editing the other metrics.
Manual testing: click to edit a dataset, go to metrics, and try to add some test in the markdown field. It should show the text.
ADDITIONAL INFORMATION