Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: rename 'tables' to 'datasets' in error message #15078

Merged
merged 1 commit into from
Jun 10, 2021

Conversation

mistercrunch
Copy link
Member

see title

@codecov
Copy link

codecov bot commented Jun 10, 2021

Codecov Report

Merging #15078 (7f39569) into master (834bb94) will decrease coverage by 0.07%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #15078      +/-   ##
==========================================
- Coverage   77.80%   77.73%   -0.08%     
==========================================
  Files         967      967              
  Lines       49668    49668              
  Branches     6326     6326              
==========================================
- Hits        38646    38607      -39     
- Misses      10821    10860      +39     
  Partials      201      201              
Flag Coverage Δ
hive 81.44% <100.00%> (ø)
mysql 81.70% <100.00%> (ø)
postgres 81.73% <100.00%> (ø)
presto ?
python 82.10% <100.00%> (-0.15%) ⬇️
sqlite 81.35% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
superset/databases/commands/exceptions.py 94.00% <100.00%> (ø)
superset/db_engine_specs/presto.py 84.42% <0.00%> (-5.48%) ⬇️
superset/connectors/sqla/models.py 88.38% <0.00%> (-1.43%) ⬇️
superset/models/core.py 89.76% <0.00%> (-0.27%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 834bb94...7f39569. Read the comment docs.

@junlincc junlincc requested a review from rusackas June 10, 2021 23:22
Copy link
Member

@rusackas rusackas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@rusackas rusackas merged commit 7d5bc24 into apache:master Jun 10, 2021
@rusackas rusackas deleted the rename_tables branch June 10, 2021 23:56
cccs-RyanS pushed a commit to CybercentreCanada/superset that referenced this pull request Dec 17, 2021
QAlexBall pushed a commit to QAlexBall/superset that referenced this pull request Dec 29, 2021
cccs-rc pushed a commit to CybercentreCanada/superset that referenced this pull request Mar 6, 2024
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 1.3.0 labels Mar 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels preset-io size/XS 🚢 1.3.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants