Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: fix typos in docs #15113

Merged
merged 6 commits into from
Jul 10, 2021
Merged

docs: fix typos in docs #15113

merged 6 commits into from
Jul 10, 2021

Conversation

jacobhjkim
Copy link
Contributor

@jacobhjkim jacobhjkim commented Jun 11, 2021 •
edited
Loading

SUMMARY

Fixes typos in docs.

resolves (#15045)

villebro
villebro approved these changes Jun 11, 2021
View reviewed changes
Copy link
Member

@villebro villebro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution @jacobhjkim !

@jacobhjkim
Copy link
Contributor Author

Do I need to bump the Helm Chart version for fixing a typo in values.yaml?

@mvoitko
Copy link
Contributor

mvoitko commented Jun 23, 2021

@jacobhjkim I guess not since it's minor document changes

@mvoitko
Copy link
Contributor

mvoitko commented Jun 23, 2021

But the lint check says you should

@jacobhjkim
Copy link
Contributor Author

@villebro updated helm chart version as well

@srinify srinify merged commit 9ed8ce5 into apache:master Jul 10, 2021
@jacobhjkim jacobhjkim deleted the fix-typo branch July 11, 2021 01:18
cccs-RyanS pushed a commit to CybercentreCanada/superset that referenced this pull request Dec 17, 2021
docs: fix typos in docs (apache#15113)
0574f29 
* Fix small typo

* shareding -> sharding

* commant -> command

* Update helm version
QAlexBall pushed a commit to QAlexBall/superset that referenced this pull request Dec 29, 2021
docs: fix typos in docs (apache#15113)
daab01f 
* Fix small typo

* shareding -> sharding

* commant -> command

* Update helm version
cccs-rc pushed a commit to CybercentreCanada/superset that referenced this pull request Mar 6, 2024
docs: fix typos in docs (apache#15113)
62d2d7f 
* Fix small typo

* shareding -> sharding

* commant -> command

* Update helm version
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 1.3.0 labels Mar 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@villebro villebro villebro approved these changes

Assignees
No one assigned
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/S 🚢 1.3.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@jacobhjkim @mvoitko @villebro @mistercrunch @srinify