Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(logging): downgrade csv export log to debug #15123

Merged
merged 3 commits into from
Jun 16, 2021

Conversation

nytai
Copy link
Member

@nytai nytai commented Jun 11, 2021

SUMMARY

This should be on debug level as it logs the entire export request which may contain sensitive info in the query.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

N/A

TESTING INSTRUCTIONS

  • Export a CSV, this line shouldn't log.
  • Set log level to DEBUG, export CSV, this line should log.

ADDITIONAL INFORMATION

  • Has associated issue:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@nytai nytai marked this pull request as ready for review June 15, 2021 23:23
@codecov
Copy link

codecov bot commented Jun 15, 2021

Codecov Report

Merging #15123 (0266790) into master (5e543e3) will increase coverage by 0.43%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #15123      +/-   ##
==========================================
+ Coverage   77.09%   77.52%   +0.43%     
==========================================
  Files         971      967       -4     
  Lines       50236    49838     -398     
  Branches     6494     6358     -136     
==========================================
- Hits        38729    38639      -90     
+ Misses      11302    10997     -305     
+ Partials      205      202       -3     
Flag Coverage Δ
hive 81.42% <100.00%> (ø)
mysql 81.70% <100.00%> (ø)
postgres 81.71% <100.00%> (ø)
python 82.09% <100.00%> (ø)
sqlite 81.34% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
superset/views/core.py 75.46% <100.00%> (ø)
.../src/dashboard/components/gridComponents/Chart.jsx 81.18% <0.00%> (-3.86%) ⬇️
...rontend/src/SqlLab/components/SqlEditorLeftBar.jsx 53.22% <0.00%> (-2.84%) ⬇️
...veFilters/FilterBar/FilterControls/FilterValue.tsx 67.44% <0.00%> (-1.38%) ⬇️
...tiveFilters/FilterBar/FilterSets/FiltersHeader.tsx 91.66% <0.00%> (-1.36%) ⬇️
...c/filters/components/Select/SelectFilterPlugin.tsx 79.04% <0.00%> (-1.14%) ⬇️
...t-frontend/src/dashboard/reducers/nativeFilters.ts 58.97% <0.00%> (-1.03%) ⬇️
...omponents/nativeFilters/FilterBar/Header/index.tsx 90.90% <0.00%> (-0.99%) ⬇️
...frontend/src/views/CRUD/welcome/DashboardTable.tsx 65.78% <0.00%> (-0.47%) ⬇️
...erset-frontend/src/SqlLab/components/SqlEditor.jsx 54.62% <0.00%> (-0.42%) ⬇️
... and 53 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5e543e3...0266790. Read the comment docs.

@pkdotson pkdotson merged commit 91e424b into apache:master Jun 16, 2021
cccs-RyanS pushed a commit to CybercentreCanada/superset that referenced this pull request Dec 17, 2021
* fix(logging): downgrade csv export log to debug

* blacking

Co-authored-by: Phillip Kelley-Dotson <pkelleydotson@yahoo.com>
QAlexBall pushed a commit to QAlexBall/superset that referenced this pull request Dec 29, 2021
* fix(logging): downgrade csv export log to debug

* blacking

Co-authored-by: Phillip Kelley-Dotson <pkelleydotson@yahoo.com>
cccs-rc pushed a commit to CybercentreCanada/superset that referenced this pull request Mar 6, 2024
* fix(logging): downgrade csv export log to debug

* blacking

Co-authored-by: Phillip Kelley-Dotson <pkelleydotson@yahoo.com>
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 1.3.0 labels Mar 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels preset-io size/XS 🚢 1.3.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants