Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(dashboard): avoid duplicated toast component #15138

Merged
merged 1 commit into from
Jun 16, 2021

Conversation

stephenLYZ
Copy link
Member

SUMMARY

This PR fixes the explore toast that will render twice when going to the dashboard. Essentially, toast has two identical components in the dashboard, it will be rendered twice.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

before

2021-06-13.5.55.30.mov

components:
image

after

2021-06-13.5.54.27.mov

components:
image

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

@codecov
Copy link

codecov bot commented Jun 14, 2021

Codecov Report

Merging #15138 (0b16956) into master (4289929) will increase coverage by 0.08%.
The diff coverage is n/a.

❗ Current head 0b16956 differs from pull request most recent head d3f2fad. Consider uploading reports for the commit d3f2fad to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master   #15138      +/-   ##
==========================================
+ Coverage   77.33%   77.41%   +0.08%     
==========================================
  Files         969      969              
  Lines       50070    49917     -153     
  Branches     6439     6393      -46     
==========================================
- Hits        38722    38644      -78     
+ Misses      11143    11070      -73     
+ Partials      205      203       -2     
Flag Coverage Δ
javascript 72.21% <ø> (+0.13%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...d/components/DashboardBuilder/DashboardBuilder.tsx 90.90% <ø> (+1.43%) ⬆️
.../src/dashboard/components/gridComponents/Chart.jsx 81.18% <0.00%> (-3.86%) ⬇️
...rontend/src/SqlLab/components/SqlEditorLeftBar.jsx 53.22% <0.00%> (-2.84%) ⬇️
...tiveFilters/FilterBar/FilterSets/FiltersHeader.tsx 91.66% <0.00%> (-1.36%) ⬇️
...c/filters/components/Select/SelectFilterPlugin.tsx 79.04% <0.00%> (-1.14%) ⬇️
...omponents/nativeFilters/FilterBar/Header/index.tsx 90.90% <0.00%> (-0.99%) ⬇️
superset/utils/webdriver.py 78.08% <0.00%> (-0.59%) ⬇️
superset/databases/api.py 92.77% <0.00%> (-0.42%) ⬇️
superset/connectors/base/models.py 88.37% <0.00%> (-0.34%) ⬇️
...tersConfigModal/FiltersConfigForm/ColumnSelect.tsx 97.14% <0.00%> (-0.23%) ⬇️
... and 32 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4289929...d3f2fad. Read the comment docs.

@villebro
Copy link
Member

@stephenLYZ this needs a rebase

Copy link
Member

@villebro villebro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@villebro villebro merged commit e689b0d into apache:master Jun 16, 2021
cccs-RyanS pushed a commit to CybercentreCanada/superset that referenced this pull request Dec 17, 2021
QAlexBall pushed a commit to QAlexBall/superset that referenced this pull request Dec 29, 2021
cccs-rc pushed a commit to CybercentreCanada/superset that referenced this pull request Mar 6, 2024
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 1.3.0 labels Mar 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/XS 🚢 1.3.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants