-
Notifications
You must be signed in to change notification settings - Fork 13.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(dashboard): avoid duplicated toast component #15138
Conversation
Codecov Report
@@ Coverage Diff @@
## master #15138 +/- ##
==========================================
+ Coverage 77.33% 77.41% +0.08%
==========================================
Files 969 969
Lines 50070 49917 -153
Branches 6439 6393 -46
==========================================
- Hits 38722 38644 -78
+ Misses 11143 11070 -73
+ Partials 205 203 -2
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
@stephenLYZ this needs a rebase |
02d3522
to
d3f2fad
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
SUMMARY
This PR fixes the explore toast that will render twice when going to the dashboard. Essentially, toast has two identical components in the dashboard, it will be rendered twice.
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
before
2021-06-13.5.55.30.mov
components:
![image](https://user-images.githubusercontent.com/11830681/121804274-1ecfaa80-cc78-11eb-8ffb-c00211eade9e.png)
after
2021-06-13.5.54.27.mov
components:
![image](https://user-images.githubusercontent.com/11830681/121804313-50487600-cc78-11eb-816a-80370573c31a.png)
TESTING INSTRUCTIONS
ADDITIONAL INFORMATION