fix: validate DB-specific parameters #15155
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #15155 +/- ##
==========================================
- Coverage 77.54% 77.53% -0.01%
==========================================
Files 967 967
Lines 49752 49783 +31
Branches 6351 6351
==========================================
+ Hits 38578 38598 +20
- Misses 10972 10983 +11
Partials 202 202
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
hughhhh
reviewed
Jun 14, 2021
hughhhh
reviewed
Jun 14, 2021
| assert rv.status_code == 200 | ||
| assert response == {"message": "OK"} | ||
|
|
||
| def test_validate_parameters_invalid_port(self): |
There was a problem hiding this comment.
Can we add validation for the range of ports allowed?
There was a problem hiding this comment.
Sure, Arash is adding that on a separate PR.
There was a problem hiding this comment.
eschutho
approved these changes
Jun 15, 2021
cccs-RyanS
pushed a commit
to CybercentreCanada/superset
that referenced
this pull request
Dec 17, 2021
* fix: validate DB-specific parameters * Fix lint * Update test * Fix lint/test * Fix lint * Update superset/databases/api.py
QAlexBall
pushed a commit
to QAlexBall/superset
that referenced
this pull request
Dec 29, 2021
* fix: validate DB-specific parameters * Fix lint * Update test * Fix lint/test * Fix lint * Update superset/databases/api.py
cccs-rc
pushed a commit
to CybercentreCanada/superset
that referenced
this pull request
Mar 6, 2024
* fix: validate DB-specific parameters * Fix lint * Update test * Fix lint/test * Fix lint * Update superset/databases/api.py
mistercrunch
added
🏷️ bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
The
validate_parametersendpoint was not performing the DB-specific Marshmallow validation (based onparameters_schema), but only the validation from thevalidate_parametersschema in the DB engine spec (which does more deep validation like checking if the host is resolvable and the port is open, but doesn't validate the schema).I changed the
DatabaseValidateParametersSchemaschema validation to also validate the DB-specific parameters, and changed the API to return the error messages expected by the frontend for theonBlurvalidation (with aninvalidkey in theextra).BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
N/A
TESTING INSTRUCTIONS
Added unit tests.
ADDITIONAL INFORMATION