Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Presto postgres test #15163

Merged
merged 1 commit into from Jun 15, 2021
Merged

fix: Presto postgres test #15163

merged 1 commit into from Jun 15, 2021

Conversation

betodealmeida
Copy link
Member

SUMMARY

We have a test consistently failing, let's fix it.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

N/A

TESTING INSTRUCTIONS

Test passes.

ADDITIONAL INFORMATION

  • Has associated issue:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@pull-request-size pull-request-size bot added size/M and removed size/S labels Jun 15, 2021
villebro
villebro approved these changes Jun 15, 2021
View reviewed changes
Copy link
Member

@villebro villebro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just noticed this today - thanks for fixing this!

@betodealmeida betodealmeida merged commit 75018bf into apache:master Jun 15, 2021
@exemplary-citizen exemplary-citizen mentioned this pull request Jun 15, 2021
Merged
8 tasks
@rusackas rusackas mentioned this pull request Jun 16, 2021
Merged
8 tasks
cccs-RyanS pushed a commit to CybercentreCanada/superset that referenced this pull request Dec 17, 2021
@betodealmeida
fix: Presto postgres test (apache#15163)
63180c1
QAlexBall pushed a commit to QAlexBall/superset that referenced this pull request Dec 29, 2021
@betodealmeida
fix: Presto postgres test (apache#15163)
2dd82e9
cccs-rc pushed a commit to CybercentreCanada/superset that referenced this pull request Mar 6, 2024
@betodealmeida
fix: Presto postgres test (apache#15163)
e09fec4
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 1.3.0 labels Mar 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@villebro villebro villebro approved these changes

Assignees
No one assigned
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/M 🚢 1.3.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@betodealmeida @villebro @mistercrunch