-
Notifications
You must be signed in to change notification settings - Fork 13.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: trim string value of spaces in listview search #15175
Conversation
this approach works, but wondering if we should add it to api since it seems like this could come up in other api calls |
Codecov Report
@@ Coverage Diff @@
## master #15175 +/- ##
==========================================
- Coverage 77.41% 77.41% -0.01%
==========================================
Files 969 969
Lines 49918 50000 +82
Branches 6393 6431 +38
==========================================
+ Hits 38645 38705 +60
- Misses 11070 11092 +22
Partials 203 203
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
SUMMARY
This pr fixes an issue with the listview search were if a space was either at the front or end of the string it would not return any results.
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
before:
https://user-images.githubusercontent.com/17326228/122089466-a540d500-cdbb-11eb-811f-1b442e0dd5cb.mov
after:
Screen.Recording.2021-06-15.at.9.29.28.AM.mov
TESTING INSTRUCTIONS
Go to listviews and try searching with spaces in string
ADDITIONAL INFORMATION