Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Makes the refresh button only appear when the filter has a datasource #15194

Merged

Conversation

michael-s-molina
Copy link
Member

SUMMARY

Makes the refresh button only appear when the filter has a datasource.

@villebro

ADDITIONAL INFORMATION

  • Has associated issue:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@codecov
Copy link

codecov bot commented Jun 16, 2021

Codecov Report

Merging #15194 (811bc09) into master (4289929) will decrease coverage by 0.00%.
The diff coverage is 33.33%.

❗ Current head 811bc09 differs from pull request most recent head 53c64b3. Consider uploading reports for the commit 53c64b3 to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master   #15194      +/-   ##
==========================================
- Coverage   77.33%   77.33%   -0.01%     
==========================================
  Files         969      969              
  Lines       50070    50072       +2     
  Branches     6439     6441       +2     
==========================================
+ Hits        38722    38723       +1     
- Misses      11143    11144       +1     
  Partials      205      205              
Flag Coverage Δ
javascript 72.08% <33.33%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...onfigModal/FiltersConfigForm/FiltersConfigForm.tsx 68.21% <33.33%> (-0.13%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4289929...53c64b3. Read the comment docs.

Copy link
Member

@villebro villebro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@villebro villebro merged commit fc8ad4f into apache:master Jun 16, 2021
cccs-RyanS pushed a commit to CybercentreCanada/superset that referenced this pull request Dec 17, 2021
QAlexBall pushed a commit to QAlexBall/superset that referenced this pull request Dec 29, 2021
cccs-rc pushed a commit to CybercentreCanada/superset that referenced this pull request Mar 6, 2024
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 1.3.0 labels Mar 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/XS 🚢 1.3.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants