style(sqllab): update table count styling #15200
Conversation
Codecov Report
@@ Coverage Diff @@
## master #15200 +/- ##
==========================================
- Coverage 77.40% 77.17% -0.23%
==========================================
Files 969 971 +2
Lines 50013 50291 +278
Branches 6431 6140 -291
==========================================
+ Hits 38712 38814 +102
- Misses 11098 11273 +175
- Partials 203 204 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
| @@ -78,6 +78,10 @@ const TableLabel = styled.span` | |||
| } | |||
| `; | |||
|
|
|||
| const smallColor = css` | |||
| color: rgba(102, 102, 102, 0.7); | |||
There was a problem hiding this comment.
@lyndsiWilliams do we have anything in supersetTheme with lower opacity?
There was a problem hiding this comment.
ah yeah, I think you should format it like this:
https://github.com/apache/superset/blob/pexdax/db-connection-ui/superset-frontend/src/views/CRUD/data/database/DatabaseModal/styles.ts#L46 (above that there is one that uses theme and css).
Instead of grayscale.base try grayscale.light1? (play around with it).
There was a problem hiding this comment.
I think colors.text.help will be the next lightest color.
There was a problem hiding this comment.
| {tableOptions.length} in | ||
| <i>{schema}</i> | ||
| <small css={smallColor}> | ||
| {tableOptions.length} {t(' ')} in {schema} |
There was a problem hiding this comment.
you don't need to wrap the space in the translate function t(' ')
There was a problem hiding this comment.
actually since they're on the same line now, you should be able to use a normal space without the string literal {' '}.
{tableOptions.length} in {schema}
|
Thanks @stellalc7 for this fix! |
|
@yousoph what are your thoughts? |
|
I deleted the string literal {' '}, and used the theme.colors.grayscale.light1 - here is the updated screenshot! |
|
Nice, thanks @stellalc7 ! |
* Change text style and opacity * Edit changes to text style and opacity for table length * Edit changes to text style and opacity
* Change text style and opacity * Edit changes to text style and opacity for table length * Edit changes to text style and opacity
* Change text style and opacity * Edit changes to text style and opacity for table length * Edit changes to text style and opacity
mistercrunch
added
🏷️ bot
SUMMARY
removed italics, and change opacity in table count text
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
BEFORE
AFTER
TESTING INSTRUCTIONS
ADDITIONAL INFORMATION