Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix dataset select list #15203

Merged
merged 1 commit into from Jun 17, 2021

Conversation

pkdotson
Copy link
Member

@pkdotson pkdotson commented Jun 16, 2021

SUMMARY

The chart listview dataset select list before would only load the first page of datasets and would not paginate. This pr fixes the issue to allow the dataset select list to paginate on scroll

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

before

Screen.Recording.2021-06-16.at.2.48.19.PM.mov

after

Screen.Recording.2021-06-16.at.2.46.40.PM.mov

TESTING INSTRUCTIONS

Go to chart listview and click on dataset select and ensure that it loads all datasets.

fixes #15131

ADDITIONAL INFORMATION

  • [ x] Has associated issue: [listview]only display 25 datasets in list view dropdown  #15131
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@codecov
Copy link

codecov bot commented Jun 16, 2021

Codecov Report

Merging #15203 (99bdc77) into master (b179863) will decrease coverage by 0.31%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #15203      +/-   ##
==========================================
- Coverage   77.48%   77.17%   -0.32%     
==========================================
  Files         969      971       +2     
  Lines       50017    50218     +201     
  Branches     6432     6494      +62     
==========================================
- Hits        38757    38755       -2     
- Misses      11055    11258     +203     
  Partials      205      205              
Flag Coverage Δ
javascript 71.61% <ø> (-0.62%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...perset-frontend/src/views/CRUD/chart/ChartList.tsx 72.66% <ø> (ø)
...d/src/filters/components/Time/TimeFilterPlugin.tsx 0.00% <0.00%> (-94.45%) ⬇️
...tend/src/filters/components/Time/transformProps.ts 22.22% <0.00%> (-44.45%) ⬇️
superset-frontend/src/dataMask/actions.ts 42.85% <0.00%> (-35.72%) ⬇️
superset-frontend/src/components/Select/utils.ts 66.66% <0.00%> (-27.46%) ⬇️
...rset-frontend/src/filters/components/Time/index.ts 88.88% <0.00%> (-11.12%) ⬇️
...et-frontend/src/filters/components/Select/index.ts 90.00% <0.00%> (-10.00%) ⬇️
...board/components/nativeFilters/FilterBar/index.tsx 82.65% <0.00%> (-8.07%) ⬇️
superset-frontend/src/dataMask/reducer.ts 64.58% <0.00%> (-6.25%) ⬇️
...d/components/DashboardBuilder/DashboardBuilder.tsx 89.36% <0.00%> (-1.67%) ⬇️
... and 14 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b179863...99bdc77. Read the comment docs.

@pkdotson pkdotson changed the title Fix: fix dataset select list fix: fix dataset select list Jun 16, 2021
@pkdotson
Copy link
Member Author

fixes #15131

@rusackas
Copy link
Member

/testenv up

@github-actions
Copy link
Contributor

@rusackas Ephemeral environment spinning up at http://54.188.85.116:8080. Credentials are admin/admin. Please allow several minutes for bootstrapping and startup.

@rusackas rusackas merged commit cb10427 into apache:master Jun 17, 2021
@rusackas rusackas deleted the fix-listview-datasetlist branch June 17, 2021 03:56
@github-actions
Copy link
Contributor

Ephemeral environment shutdown and build artifacts deleted.

cccs-RyanS pushed a commit to CybercentreCanada/superset that referenced this pull request Dec 17, 2021
QAlexBall pushed a commit to QAlexBall/superset that referenced this pull request Dec 29, 2021
cccs-rc pushed a commit to CybercentreCanada/superset that referenced this pull request Mar 6, 2024
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 1.3.0 labels Mar 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels preset-io size/XS 🚢 1.3.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[listview]only display 25 datasets in list view dropdown
4 participants