-
Notifications
You must be signed in to change notification settings - Fork 13.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: implement specific errors for SQL Lab #15206
Conversation
Codecov Report
@@ Coverage Diff @@
## master #15206 +/- ##
==========================================
- Coverage 77.25% 77.00% -0.26%
==========================================
Files 971 973 +2
Lines 50308 50493 +185
Branches 6140 6182 +42
==========================================
+ Hits 38867 38880 +13
- Misses 11237 11407 +170
- Partials 204 206 +2
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚀
Results backend needed for asynchronous queries is not configured. | ||
``` | ||
|
||
Your instance of Superset doesn't have a results backend configured, which is needed for asynchronous queries. Please contact an administrator for further assistance. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we point them to the docs on how to configure this as well?
* RESULTS_BACKEND_NOT_CONFIGURED_ERROR * DML_NOT_ALLOWED_ERROR * INVALID_CxAS_QUERY_ERROR * Fix lint * Add more tests
* RESULTS_BACKEND_NOT_CONFIGURED_ERROR * DML_NOT_ALLOWED_ERROR * INVALID_CxAS_QUERY_ERROR * Fix lint * Add more tests
* RESULTS_BACKEND_NOT_CONFIGURED_ERROR * DML_NOT_ALLOWED_ERROR * INVALID_CxAS_QUERY_ERROR * Fix lint * Add more tests
SUMMARY
This PR adds custom errors to some of SQL Lab error responses:
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
TESTING INSTRUCTIONS
Updated unit tests and tested manually.
ADDITIONAL INFORMATION