-
Notifications
You must be signed in to change notification settings - Fork 13.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(native-filters): Fix Select Default First Value
by clicked Clear All
#15219
Conversation
� Conflicts: � superset-frontend/src/dashboard/util/getPermissions.ts
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM - this distinction between undefined
and null
will be important to record in the documentation (making a note of this to myself to add to the docs).
Codecov Report
@@ Coverage Diff @@
## master #15219 +/- ##
========================================
Coverage 77.08% 77.08%
========================================
Files 971 971
Lines 50242 50243 +1
Branches 6498 6112 -386
========================================
+ Hits 38731 38732 +1
- Misses 11306 11308 +2
+ Partials 205 203 -2
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
…ar All` (apache#15219) * fix:fix get permission function * fix: fix select first value by clear all * lint: fix lint
…ar All` (apache#15219) * fix:fix get permission function * fix: fix select first value by clear all * lint: fix lint
…ar All` (apache#15219) * fix:fix get permission function * fix: fix select first value by clear all * lint: fix lint
SUMMARY
Fixes: #15213
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
TESTING INSTRUCTIONS
ADDITIONAL INFORMATION