Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(native-filters): Fix Select Default First Value by clicked Clear All #15219

Merged
merged 14 commits into from
Jun 17, 2021

Conversation

simcha90
Copy link
Contributor

SUMMARY

Fixes: #15213

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

  • Has associated issue:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

Copy link
Member

@villebro villebro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - this distinction between undefined and null will be important to record in the documentation (making a note of this to myself to add to the docs).

@codecov
Copy link

codecov bot commented Jun 17, 2021

Codecov Report

Merging #15219 (3b3f1ca) into master (e5187a4) will increase coverage by 0.00%.
The diff coverage is 66.66%.

❗ Current head 3b3f1ca differs from pull request most recent head 4b16faf. Consider uploading reports for the commit 4b16faf to get more accurate results
Impacted file tree graph

@@           Coverage Diff            @@
##           master   #15219    +/-   ##
========================================
  Coverage   77.08%   77.08%            
========================================
  Files         971      971            
  Lines       50242    50243     +1     
  Branches     6498     6112   -386     
========================================
+ Hits        38731    38732     +1     
- Misses      11306    11308     +2     
+ Partials      205      203     -2     
Flag Coverage Δ
javascript 71.60% <66.66%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...omponents/nativeFilters/FilterBar/Header/index.tsx 91.89% <0.00%> (ø)
superset-frontend/src/dataMask/reducer.ts 65.30% <100.00%> (+0.72%) ⬆️
superset-frontend/src/views/CRUD/hooks.ts 53.02% <0.00%> (ø)
...end/src/SqlLab/components/RunQueryActionButton.tsx 64.28% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e5187a4...4b16faf. Read the comment docs.

@villebro villebro merged commit fe5381d into apache:master Jun 17, 2021
cccs-RyanS pushed a commit to CybercentreCanada/superset that referenced this pull request Dec 17, 2021
…ar All` (apache#15219)

* fix:fix get permission function

* fix: fix select first value by clear all

* lint: fix lint
QAlexBall pushed a commit to QAlexBall/superset that referenced this pull request Dec 29, 2021
…ar All` (apache#15219)

* fix:fix get permission function

* fix: fix select first value by clear all

* lint: fix lint
cccs-rc pushed a commit to CybercentreCanada/superset that referenced this pull request Mar 6, 2024
…ar All` (apache#15219)

* fix:fix get permission function

* fix: fix select first value by clear all

* lint: fix lint
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 1.3.0 labels Mar 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/S 🚢 1.3.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[native-filters] clicking "clear all" doesn't remove value if "default to first value" is selected
3 participants