chore: move calling configure_feature_flags more earlier #15223
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amitmiran137
changed the title
Codecov Report
@@ Coverage Diff @@
## master #15223 +/- ##
=======================================
Coverage 77.16% 77.16%
=======================================
Files 971 971
Lines 50243 50243
Branches 6112 6112
=======================================
Hits 38772 38772
Misses 11268 11268
Partials 203 203
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
amitmiran137
force-pushed
the
chore/move_init_feature_flags_upper
branch
from
c6bb96f
to
a2973d1
Compare
amitmiran137
approved these changes
Jun 21, 2021
cccs-RyanS
pushed a commit
to CybercentreCanada/superset
that referenced
this pull request
Dec 17, 2021
Co-authored-by: Ofeknielsen <ofek.israel@nieslen.com>
QAlexBall
pushed a commit
to QAlexBall/superset
that referenced
this pull request
Dec 29, 2021
Co-authored-by: Ofeknielsen <ofek.israel@nieslen.com>
cccs-rc
pushed a commit
to CybercentreCanada/superset
that referenced
this pull request
Mar 6, 2024
Co-authored-by: Ofeknielsen <ofek.israel@nieslen.com>
mistercrunch
added
🏷️ bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
In order to allow init new features conditionally based on features flags, the feature flags manager should be initiated as soon as possible.
For example, as a future pull request, I would like to add a new feature that affects the db setup based on feature flag, so the new feature should be initiated before setup DB