Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Filter bar not occupying 100% height when filter sets FF unset #15228

Merged

Conversation

michael-s-molina
Copy link
Member

SUMMARY

Fixes #15218

@villebro @kgabryje @rusackas

AFTER VIDEO

screen-recording-2021-06-17-at-95802-am_nIjHIhp7.mov

TESTING INSTRUCTIONS

See the original issue for instructions.

ADDITIONAL INFORMATION

  • Has associated issue:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@codecov
Copy link

codecov bot commented Jun 17, 2021

Codecov Report

Merging #15228 (33405bb) into master (7237324) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #15228   +/-   ##
=======================================
  Coverage   77.16%   77.17%           
=======================================
  Files         971      971           
  Lines       50243    50248    +5     
  Branches     6112     6113    +1     
=======================================
+ Hits        38772    38777    +5     
  Misses      11268    11268           
  Partials      203      203           
Flag Coverage Δ
javascript 71.77% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...d/components/DashboardBuilder/DashboardBuilder.tsx 89.89% <100.00%> (+0.53%) ⬆️
...board/components/nativeFilters/FilterBar/index.tsx 90.81% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7237324...33405bb. Read the comment docs.

Copy link
Member

@villebro villebro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - tested with NF and NF+FS, works well with both

Comment on lines -58 to +60
const FILTER_BAR_HEADER_HEIGHT = 128;
const FILTER_BAR_HEADER_HEIGHT = 80;
const FILTER_BAR_TABS_HEIGHT = 46;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

any reason for the 2 px difference?

@villebro villebro merged commit ea8507b into apache:master Jun 17, 2021
cccs-RyanS pushed a commit to CybercentreCanada/superset that referenced this pull request Dec 17, 2021
QAlexBall pushed a commit to QAlexBall/superset that referenced this pull request Dec 29, 2021
cccs-rc pushed a commit to CybercentreCanada/superset that referenced this pull request Mar 6, 2024
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 1.3.0 labels Mar 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/S 🚢 1.3.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[native-filters] filter bar not occupying 100 % height when filter sets FF unset
3 participants