-
Notifications
You must be signed in to change notification settings - Fork 13.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Filter bar not occupying 100% height when filter sets FF unset #15228
fix: Filter bar not occupying 100% height when filter sets FF unset #15228
Conversation
Codecov Report
@@ Coverage Diff @@
## master #15228 +/- ##
=======================================
Coverage 77.16% 77.17%
=======================================
Files 971 971
Lines 50243 50248 +5
Branches 6112 6113 +1
=======================================
+ Hits 38772 38777 +5
Misses 11268 11268
Partials 203 203
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM - tested with NF and NF+FS, works well with both
const FILTER_BAR_HEADER_HEIGHT = 128; | ||
const FILTER_BAR_HEADER_HEIGHT = 80; | ||
const FILTER_BAR_TABS_HEIGHT = 46; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
any reason for the 2 px difference?
SUMMARY
Fixes #15218
@villebro @kgabryje @rusackas
AFTER VIDEO
screen-recording-2021-06-17-at-95802-am_nIjHIhp7.mov
TESTING INSTRUCTIONS
See the original issue for instructions.
ADDITIONAL INFORMATION