feat(editable-title): move cursor and scroll to the end #15270
Conversation
Codecov Report
@@ Coverage Diff @@
## master #15270 +/- ##
=======================================
Coverage 77.26% 77.26%
=======================================
Files 971 971
Lines 50308 50313 +5
Branches 6140 6141 +1
=======================================
+ Hits 38869 38874 +5
Misses 11235 11235
Partials 204 204
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
| const { length } = contentRef.current.value; | ||
| contentRef.current.setSelectionRange(length, length); | ||
| contentRef.current.scrollLeft = contentRef.current.scrollWidth; | ||
| contentRef.current.scrollTop = contentRef.current.scrollHeight; |
There was a problem hiding this comment.
Not sure if this is needed (setting scrollTop), but it probably doesn't hurt, either
There was a problem hiding this comment.
Cool. Here I think it need to scroll to the bottom for the textarea.
There was a problem hiding this comment.
Cool. Here I think it need to scroll to the bottom for the textarea.
Right you are! 👍
mistercrunch
added
🏷️ bot
SUMMARY
This PR improves the UX of editable title component. Move the cursor and scroll to the end when focusing, for easier delete.
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
before
Screen.Recording.2021-06-11.at.6.09.02.PM.mov
after
2021-06-19.7.09.10.mov
TESTING INSTRUCTIONS
ADDITIONAL INFORMATION