Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(native-filters): Show/Highlight errored/focused status #15276

Merged
merged 17 commits into from
Jun 22, 2021

Conversation

simcha90
Copy link
Contributor

SUMMARY

  1. Add highlight status for all filters when user select filter in filter badge
  2. Add error status for filters that should be required

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

Screen.Recording.2021-06-21.at.9.21.06.mov

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

  • Has associated issue:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@simcha90 simcha90 closed this Jun 21, 2021
@simcha90 simcha90 reopened this Jun 21, 2021
@codecov
Copy link

codecov bot commented Jun 21, 2021

Codecov Report

Merging #15276 (9bf6959) into master (1948678) will decrease coverage by 0.01%.
The diff coverage is 45.76%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #15276      +/-   ##
==========================================
- Coverage   77.25%   77.24%   -0.02%     
==========================================
  Files         973      973              
  Lines       50393    50430      +37     
  Branches     6147     6170      +23     
==========================================
+ Hits        38933    38954      +21     
- Misses      11256    11271      +15     
- Partials      204      205       +1     
Flag Coverage Δ
javascript 71.80% <45.76%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...veFilters/FilterBar/FilterControls/FilterValue.tsx 71.13% <ø> (-0.30%) ⬇️
...tersConfigModal/FiltersConfigForm/DefaultValue.tsx 20.83% <0.00%> (-4.17%) ⬇️
...onfigModal/FiltersConfigForm/FiltersConfigForm.tsx 70.00% <0.00%> (ø)
...filters/components/GroupBy/GroupByFilterPlugin.tsx 0.00% <0.00%> (ø)
...end/src/filters/components/GroupBy/controlPanel.ts 100.00% <ø> (ø)
...ntend/src/filters/components/Range/controlPanel.ts 100.00% <ø> (ø)
...s/components/TimeColumn/TimeColumnFilterPlugin.tsx 0.00% <0.00%> (ø)
...ers/components/TimeGrain/TimeGrainFilterPlugin.tsx 0.00% <0.00%> (ø)
...d/src/filters/components/Time/TimeFilterPlugin.tsx 91.30% <83.33%> (-3.15%) ⬇️
...src/filters/components/Range/RangeFilterPlugin.tsx 90.90% <100.00%> (+2.22%) ⬆️
... and 5 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1948678...9bf6959. Read the comment docs.

Copy link
Member

@villebro villebro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few comments

� Conflicts:
�	superset-frontend/src/filters/components/Select/controlPanel.ts
Copy link
Member

@villebro villebro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks so much for this awesome work!

@villebro villebro merged commit 048609d into apache:master Jun 22, 2021
cccs-RyanS pushed a commit to CybercentreCanada/superset that referenced this pull request Dec 17, 2021
…5276)

* fix:fix get permission function

* feat: show error status for required filters

* test: fix tests

* refactor: fix CR notes
QAlexBall pushed a commit to QAlexBall/superset that referenced this pull request Dec 29, 2021
…5276)

* fix:fix get permission function

* feat: show error status for required filters

* test: fix tests

* refactor: fix CR notes
cccs-rc pushed a commit to CybercentreCanada/superset that referenced this pull request Mar 6, 2024
…5276)

* fix:fix get permission function

* feat: show error status for required filters

* test: fix tests

* refactor: fix CR notes
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 1.3.0 labels Mar 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/L 🚢 1.3.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants