-
Notifications
You must be signed in to change notification settings - Fork 13.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(native-filters): Show/Highlight errored/focused status #15276
Conversation
� Conflicts: � superset-frontend/src/dashboard/util/getPermissions.ts
Codecov Report
@@ Coverage Diff @@
## master #15276 +/- ##
==========================================
- Coverage 77.25% 77.24% -0.02%
==========================================
Files 973 973
Lines 50393 50430 +37
Branches 6147 6170 +23
==========================================
+ Hits 38933 38954 +21
- Misses 11256 11271 +15
- Partials 204 205 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few comments
superset-frontend/src/filters/components/Range/RangeFilterPlugin.tsx
Outdated
Show resolved
Hide resolved
superset-frontend/src/filters/components/Range/RangeFilterPlugin.tsx
Outdated
Show resolved
Hide resolved
superset-frontend/src/filters/components/Range/RangeFilterPlugin.tsx
Outdated
Show resolved
Hide resolved
� Conflicts: � superset-frontend/src/filters/components/Select/controlPanel.ts
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks so much for this awesome work!
…5276) * fix:fix get permission function * feat: show error status for required filters * test: fix tests * refactor: fix CR notes
…5276) * fix:fix get permission function * feat: show error status for required filters * test: fix tests * refactor: fix CR notes
…5276) * fix:fix get permission function * feat: show error status for required filters * test: fix tests * refactor: fix CR notes
SUMMARY
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
Screen.Recording.2021-06-21.at.9.21.06.mov
TESTING INSTRUCTIONS
ADDITIONAL INFORMATION