Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: bootstrapScript in values.yaml of the helm chart #15297

Merged
merged 1 commit into from
Jun 27, 2021
Merged

fix: bootstrapScript in values.yaml of the helm chart #15297

merged 1 commit into from
Jun 27, 2021

Conversation

mvoitko
Copy link
Contributor

@mvoitko mvoitko commented Jun 22, 2021

SUMMARY

The bootstrap script had Syntax Errors and unnecessary nano installation.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

cd helm/charts
helm install .

ADDITIONAL INFORMATION

  • Has associated issue:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@mvoitko mvoitko changed the title Fix bootstrapScript in values.yaml of the helm chart fix: bootstrapScript in values.yaml of the helm chart Jun 24, 2021
@mvoitko mvoitko force-pushed the fix/bootstrapScript-values-in-helm-chart branch from 096d9c5 to 38dc0ea Compare June 27, 2021 10:29
@mvoitko
Copy link
Contributor Author

mvoitko commented Jun 27, 2021

@craig-rueda Could you please review?

@craig-rueda craig-rueda merged commit a3d91ae into apache:master Jun 27, 2021
@mvoitko mvoitko deleted the fix/bootstrapScript-values-in-helm-chart branch June 28, 2021 09:56
mvoitko added a commit to mvoitko/superset that referenced this pull request Jun 28, 2021
@mvoitko
Fix bootstrapScript in values.yaml of the helm chart (apache#15297)
9240051
cccs-RyanS pushed a commit to CybercentreCanada/superset that referenced this pull request Dec 17, 2021
@mvoitko
Fix bootstrapScript in values.yaml of the helm chart (apache#15297)
9f7b1ba
QAlexBall pushed a commit to QAlexBall/superset that referenced this pull request Dec 29, 2021
@mvoitko
Fix bootstrapScript in values.yaml of the helm chart (apache#15297)
fd8758e
cccs-rc pushed a commit to CybercentreCanada/superset that referenced this pull request Mar 6, 2024
@mvoitko
Fix bootstrapScript in values.yaml of the helm chart (apache#15297)
5364dc9
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 1.3.0 labels Mar 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@craig-rueda craig-rueda craig-rueda approved these changes

Assignees
No one assigned
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/S 🚢 1.3.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@mvoitko @craig-rueda @mistercrunch