fix: Revert "fix: SQL Lab show "Refetch Results" button while fetching new query results" #15301
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
graceguo-supercat
changed the title
serenajiang
approved these changes
Jun 22, 2021
Codecov Report
@@ Coverage Diff @@
## master #15301 +/- ##
=======================================
Coverage 77.24% 77.25%
=======================================
Files 973 973
Lines 50438 50432 -6
Branches 6175 6171 -4
=======================================
Hits 38959 38959
+ Misses 11274 11268 -6
Partials 205 205
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
cccs-RyanS
pushed a commit
to CybercentreCanada/superset
that referenced
this pull request
Dec 17, 2021
… query results (apache#15109)" (apache#15301) This reverts commit 408d58f.
QAlexBall
pushed a commit
to QAlexBall/superset
that referenced
this pull request
Dec 29, 2021
… query results (apache#15109)" (apache#15301) This reverts commit 408d58f.
cccs-rc
pushed a commit
to CybercentreCanada/superset
that referenced
this pull request
Mar 6, 2024
… query results (apache#15109)" (apache#15301) This reverts commit e82ca65.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #15109
This PR fixed the "Refetch Results" button as expected, but it seems it introduced another issue in airbnb. Some of our users saw "offline" message when they start new query. I am not sure the root cause yet, but have to revert to PR and investigate more.