Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: Icon to icons for certifiedIcon #15306

Merged
merged 3 commits into from
Jun 23, 2021
Merged

refactor: Icon to icons for certifiedIcon #15306

merged 3 commits into from
Jun 23, 2021

Conversation

pkdotson
Copy link
Member

SUMMARY

This pr refactors the certifiedIcon to icon to icons

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

Before
SQL expression
SEE TABLE SCHEMA 67 IN INFORMATION_SCHEMA
Database

After

Database

sum(SP_POP_T0TL)

SEE TABLE SCHEMA 67 ININFORMATION_SCHEMA

TESTING INSTRUCTIONS

Test out in
datasource selector modal
dateset editor
and tab drop down in sqleditor

ADDITIONAL INFORMATION

  • Has associated issue:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@pkdotson pkdotson changed the title refactor: Icon to icons for cerftifiedIcon refactor: Icon to icons for certifiedIcon Jun 22, 2021
@codecov
Copy link

codecov bot commented Jun 22, 2021

Codecov Report

Merging #15306 (c27c167) into master (ab153e6) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #15306   +/-   ##
=======================================
  Coverage   77.14%   77.15%           
=======================================
  Files         973      973           
  Lines       50473    50470    -3     
  Branches     6183     6180    -3     
=======================================
  Hits        38938    38938           
+ Misses      11329    11326    -3     
  Partials      206      206
Flag Coverage Δ
javascript 71.76% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...et-frontend/src/components/TableSelector/index.tsx 84.92% <ø> (ø)
...erset-frontend/src/datasource/DatasourceEditor.jsx 74.39% <ø> (ø)
...ontend/src/views/CRUD/data/dataset/DatasetList.tsx 70.05% <ø> (ø)
...et-frontend/src/components/CertifiedIcon/index.tsx 100.00% <100.00%> (ø)
...rset-frontend/src/components/Select/AntdSelect.tsx
superset-frontend/src/components/Select/Select.tsx 0.00% <0.00%> (ø)
superset-frontend/src/SqlLab/reducers/sqlLab.js 34.95% <0.00%> (+0.83%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ab153e6...c27c167. Read the comment docs.

michael-s-molina
michael-s-molina approved these changes Jun 23, 2021
View reviewed changes
Copy link
Member

@michael-s-molina michael-s-molina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rusackas
Copy link
Member

/testenv up

@github-actions
Copy link
Contributor

@rusackas Ephemeral environment spinning up at http://34.219.118.23:8080. Credentials are admin/admin. Please allow several minutes for bootstrapping and startup.

rusackas
rusackas approved these changes Jun 23, 2021
View reviewed changes
Copy link
Member

@rusackas rusackas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@rusackas rusackas merged commit e1ceb7f into apache:master Jun 23, 2021
@rusackas rusackas deleted the certifiedIcon branch June 23, 2021 20:49
@github-actions
Copy link
Contributor

Ephemeral environment shutdown and build artifacts deleted.

cccs-RyanS pushed a commit to CybercentreCanada/superset that referenced this pull request Dec 17, 2021
@pkdotson
refactor: Icon to icons for certifiedIcon (apache#15306)
3dde3aa 
* initial commit

* updated css

* fix lint
QAlexBall pushed a commit to QAlexBall/superset that referenced this pull request Dec 29, 2021
@pkdotson
refactor: Icon to icons for certifiedIcon (apache#15306)
ab9da82 
* initial commit

* updated css

* fix lint
cccs-rc pushed a commit to CybercentreCanada/superset that referenced this pull request Mar 6, 2024
@pkdotson
refactor: Icon to icons for certifiedIcon (apache#15306)
4e6e15c 
* initial commit

* updated css

* fix lint
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 1.3.0 labels Mar 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rusackas rusackas rusackas approved these changes

@michael-s-molina michael-s-molina michael-s-molina approved these changes

@suddjian suddjian Awaiting requested review from suddjian

@kgabryje kgabryje Awaiting requested review from kgabryje

Assignees
No one assigned
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels preset-io size/S 🚢 1.3.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@pkdotson @rusackas @michael-s-molina @mistercrunch