Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: migrate icon to icons in tablecollection #15309

Merged
merged 3 commits into from
Jun 23, 2021

Conversation

pkdotson
Copy link
Member

@pkdotson pkdotson commented Jun 22, 2021

SUMMARY

migrates the sort icon to icons in the listviews and also fixes a flaky/broken test on master.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

before
Dataset

after
Dataset

TESTING INSTRUCTIONS

checkout any of the listviews sort icons in the table

ADDITIONAL INFORMATION

  • Has associated issue:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@codecov
Copy link

codecov bot commented Jun 23, 2021

Codecov Report

Merging #15309 (57df337) into master (fc1a62b) will increase coverage by 0.00%.
The diff coverage is 85.71%.

❗ Current head 57df337 differs from pull request most recent head e3fd4e7. Consider uploading reports for the commit e3fd4e7 to get more accurate results
Impacted file tree graph

@@           Coverage Diff           @@
##           master   #15309   +/-   ##
=======================================
  Coverage   77.22%   77.23%           
=======================================
  Files         973      973           
  Lines       50470    50478    +8     
  Branches     6180     6182    +2     
=======================================
+ Hits        38977    38985    +8     
  Misses      11287    11287           
  Partials      206      206           
Flag Coverage Δ
javascript 71.76% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
superset/views/sql_lab.py 60.68% <ø> (ø)
superset/views/core.py 75.54% <71.42%> (-0.04%) ⬇️
.../src/components/dataViewCommon/TableCollection.tsx 100.00% <100.00%> (ø)
...erset-frontend/src/datasource/DatasourceEditor.jsx 74.59% <100.00%> (+0.20%) ⬆️
superset/db_engine_specs/presto.py 90.31% <0.00%> (+0.42%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fc1a62b...e3fd4e7. Read the comment docs.

@pkdotson pkdotson merged commit f35ce39 into apache:master Jun 23, 2021
@villebro villebro deleted the tableColletion-icons branch September 24, 2021 08:09
cccs-RyanS pushed a commit to CybercentreCanada/superset that referenced this pull request Dec 17, 2021
* initial commit

* fix flaky test

* remove line
QAlexBall pushed a commit to QAlexBall/superset that referenced this pull request Dec 29, 2021
* initial commit

* fix flaky test

* remove line
cccs-rc pushed a commit to CybercentreCanada/superset that referenced this pull request Mar 6, 2024
* initial commit

* fix flaky test

* remove line
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 1.3.0 labels Mar 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels preset-io size/S 🚢 1.3.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants