-
Notifications
You must be signed in to change notification settings - Fork 13.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: migrate icon to icons in tablecollection #15309
Conversation
Codecov Report
@@ Coverage Diff @@
## master #15309 +/- ##
=======================================
Coverage 77.22% 77.23%
=======================================
Files 973 973
Lines 50470 50478 +8
Branches 6180 6182 +2
=======================================
+ Hits 38977 38985 +8
Misses 11287 11287
Partials 206 206
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
* initial commit * fix flaky test * remove line
* initial commit * fix flaky test * remove line
* initial commit * fix flaky test * remove line
SUMMARY
migrates the sort icon to icons in the listviews and also fixes a flaky/broken test on master.
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
before
![Dataset](https://user-images.githubusercontent.com/17326228/123001909-1fe29500-d366-11eb-9c16-cf664f7416d5.png)
after
![Dataset](https://user-images.githubusercontent.com/17326228/123001923-25d87600-d366-11eb-9a1c-1de15fffa29e.png)
TESTING INSTRUCTIONS
checkout any of the listviews sort icons in the table
ADDITIONAL INFORMATION