fix(native-filters): Assume that temporal columns exist if column_types is undefined #15324
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
villebro
reviewed
Jun 23, 2021
Comment on lines
280
to
281
| ) => dataset?.column_types?.includes(GenericDataType.TEMPORAL); | ||
| ) => dataset?.column_types?.includes(GenericDataType.TEMPORAL) ?? true; |
There was a problem hiding this comment.
Could we make it even more bulletproof by checking for length of column_types? Something like !dataset?.column_types?.length || dataset?.column_types?.includes(GenericDataType.TEMPORAL)? The reason is I suspect the Druid connector might return an empty array.
Codecov Report
@@ Coverage Diff @@
## master #15324 +/- ##
==========================================
- Coverage 77.15% 77.15% -0.01%
==========================================
Files 973 973
Lines 50488 50491 +3
Branches 6184 6184
==========================================
+ Hits 38954 38956 +2
- Misses 11328 11329 +1
Partials 206 206
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
villebro
approved these changes
Jun 23, 2021
cccs-RyanS
pushed a commit
to CybercentreCanada/superset
that referenced
this pull request
Dec 17, 2021
…es is undefined (apache#15324) * fix(native-filters): Assume that temporal columns exist if column_types is undefined * Allow column_types to be an empty array
QAlexBall
pushed a commit
to QAlexBall/superset
that referenced
this pull request
Dec 29, 2021
…es is undefined (apache#15324) * fix(native-filters): Assume that temporal columns exist if column_types is undefined * Allow column_types to be an empty array
cccs-rc
pushed a commit
to CybercentreCanada/superset
that referenced
this pull request
Mar 6, 2024
…es is undefined (apache#15324) * fix(native-filters): Assume that temporal columns exist if column_types is undefined * Allow column_types to be an empty array
mistercrunch
added
🏷️ bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Currently, if for some reason backend doesn't return
column_typesfield in datasets query, we disable selecting time filters in native filters modal. This PR makes the feature more foolproof, by assuming that temporal columns exist ifcolumn_typesis undefined.BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
TESTING INSTRUCTIONS
ADDITIONAL INFORMATION
CC @villebro @graceguo-supercat