Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: icon to icons for basicerror componenet #15336

Merged
merged 7 commits into from Jun 24, 2021

Conversation

pkdotson
Copy link
Member

SUMMARY

This pr refactors the basicerror icon to icons.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

before
Cannot load filter
Screen Shot 2021-06-23 at 10 53 33 AM
after
Cannot load filter
Screen Shot 2021-06-23 at 10 53 33 AM

TESTING INSTRUCTIONS

To test you must enable nativefilters feature flags and check the filterconfigmodal and filterbox for the basic error alert.

ADDITIONAL INFORMATION

  • Has associated issue:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@codecov
Copy link

codecov bot commented Jun 23, 2021

Codecov Report

Merging #15336 (b5c7407) into master (b295c6a) will increase coverage by 0.01%.
The diff coverage is 87.12%.

❗ Current head b5c7407 differs from pull request most recent head 03a3e9f. Consider uploading reports for the commit 03a3e9f to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master   #15336      +/-   ##
==========================================
+ Coverage   77.16%   77.17%   +0.01%     
==========================================
  Files         973      975       +2     
  Lines       50523    50585      +62     
  Branches     6184     6203      +19     
==========================================
+ Hits        38986    39039      +53     
- Misses      11331    11339       +8     
- Partials      206      207       +1     
Flag Coverage Δ
javascript 71.79% <86.51%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...nd/src/common/hooks/useComponentDidUpdate/index.ts 0.00% <0.00%> (ø)
...rset-frontend/src/components/ErrorMessage/types.ts 100.00% <ø> (ø)
...ilterScopingModal/CrossFilterScopingForm/index.tsx 84.61% <ø> (ø)
...erset-frontend/src/datasource/DatasourceEditor.jsx 74.59% <ø> (ø)
...l/AdhocFilterEditPopoverSimpleTabContent/index.tsx 65.68% <0.00%> (ø)
superset-frontend/src/setup/setupErrorMessages.ts 0.00% <0.00%> (ø)
...ontend/src/views/CRUD/data/dataset/DatasetList.tsx 70.05% <ø> (ø)
...ConfigModal/FiltersConfigForm/FilterScope/state.ts 95.65% <66.66%> (-4.35%) ⬇️
superset/viz.py 56.52% <66.66%> (+0.05%) ⬆️
...odal/FiltersConfigForm/FilterScope/ScopingTree.tsx 90.62% <80.00%> (-5.03%) ⬇️
... and 13 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b295c6a...03a3e9f. Read the comment docs.

Copy link
Member

@suddjian suddjian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, minus a residual commented line

Co-authored-by: David Aaron Suddjian <1858430+suddjian@users.noreply.github.com>
@pkdotson pkdotson merged commit a477505 into apache:master Jun 24, 2021
cccs-RyanS pushed a commit to CybercentreCanada/superset that referenced this pull request Dec 17, 2021
* initial commit

* initial commit

* fix test

* lint fix

* Update superset-frontend/src/components/ErrorMessage/BasicErrorAlert.tsx

Co-authored-by: David Aaron Suddjian <1858430+suddjian@users.noreply.github.com>

* lint

Co-authored-by: David Aaron Suddjian <1858430+suddjian@users.noreply.github.com>
QAlexBall pushed a commit to QAlexBall/superset that referenced this pull request Dec 29, 2021
* initial commit

* initial commit

* fix test

* lint fix

* Update superset-frontend/src/components/ErrorMessage/BasicErrorAlert.tsx

Co-authored-by: David Aaron Suddjian <1858430+suddjian@users.noreply.github.com>

* lint

Co-authored-by: David Aaron Suddjian <1858430+suddjian@users.noreply.github.com>
cccs-rc pushed a commit to CybercentreCanada/superset that referenced this pull request Mar 6, 2024
* initial commit

* initial commit

* fix test

* lint fix

* Update superset-frontend/src/components/ErrorMessage/BasicErrorAlert.tsx

Co-authored-by: David Aaron Suddjian <1858430+suddjian@users.noreply.github.com>

* lint

Co-authored-by: David Aaron Suddjian <1858430+suddjian@users.noreply.github.com>
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 1.3.0 labels Mar 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels preset-io size/S 🚢 1.3.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants