New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: icon to icons for basicerror componenet #15336
Conversation
Codecov Report
@@ Coverage Diff @@
## master #15336 +/- ##
==========================================
+ Coverage 77.16% 77.17% +0.01%
==========================================
Files 973 975 +2
Lines 50523 50585 +62
Branches 6184 6203 +19
==========================================
+ Hits 38986 39039 +53
- Misses 11331 11339 +8
- Partials 206 207 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
superset-frontend/src/components/ErrorMessage/BasicErrorAlert.tsx
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, minus a residual commented line
Co-authored-by: David Aaron Suddjian <1858430+suddjian@users.noreply.github.com>
* initial commit * initial commit * fix test * lint fix * Update superset-frontend/src/components/ErrorMessage/BasicErrorAlert.tsx Co-authored-by: David Aaron Suddjian <1858430+suddjian@users.noreply.github.com> * lint Co-authored-by: David Aaron Suddjian <1858430+suddjian@users.noreply.github.com>
* initial commit * initial commit * fix test * lint fix * Update superset-frontend/src/components/ErrorMessage/BasicErrorAlert.tsx Co-authored-by: David Aaron Suddjian <1858430+suddjian@users.noreply.github.com> * lint Co-authored-by: David Aaron Suddjian <1858430+suddjian@users.noreply.github.com>
* initial commit * initial commit * fix test * lint fix * Update superset-frontend/src/components/ErrorMessage/BasicErrorAlert.tsx Co-authored-by: David Aaron Suddjian <1858430+suddjian@users.noreply.github.com> * lint Co-authored-by: David Aaron Suddjian <1858430+suddjian@users.noreply.github.com>
SUMMARY
This pr refactors the basicerror icon to icons.
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
before
after
TESTING INSTRUCTIONS
To test you must enable nativefilters feature flags and check the filterconfigmodal and filterbox for the basic error alert.
ADDITIONAL INFORMATION