Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(explore): Fix issue #15335 - Filter comparator losing focus #15339

Merged
merged 1 commit into from Jun 24, 2021

Conversation

m-ajay
Copy link
Contributor

@m-ajay m-ajay commented Jun 23, 2021

SUMMARY

Fixes issue #15335

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

Filter_Fixed

TESTING INSTRUCTIONS

Manual

ADDITIONAL INFORMATION

  • Has associated issue:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@codecov
Copy link

codecov bot commented Jun 23, 2021

Codecov Report

Merging #15339 (fb9e874) into master (c7c6375) will decrease coverage by 0.09%.
The diff coverage is 72.49%.

❗ Current head fb9e874 differs from pull request most recent head ad28c15. Consider uploading reports for the commit ad28c15 to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master   #15339      +/-   ##
==========================================
- Coverage   77.25%   77.16%   -0.10%     
==========================================
  Files         971      973       +2     
  Lines       50308    50523     +215     
  Branches     6140     6184      +44     
==========================================
+ Hits        38867    38986     +119     
- Misses      11237    11331      +94     
- Partials      204      206       +2     
Flag Coverage Δ
javascript 71.76% <43.62%> (-0.05%) ⬇️
presto ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
superset-frontend/src/CRUD/CollectionTable.tsx 78.91% <ø> (ø)
superset-frontend/src/SqlLab/reducers/sqlLab.js 34.95% <0.00%> (+0.83%) ⬆️
...rset-frontend/src/components/ErrorMessage/types.ts 100.00% <ø> (ø)
superset-frontend/src/components/Select/Select.tsx 0.00% <0.00%> (ø)
superset-frontend/src/components/Select/utils.ts 66.66% <ø> (ø)
...et-frontend/src/components/TableSelector/index.tsx 84.92% <ø> (ø)
superset-frontend/src/components/index.ts 0.00% <0.00%> (ø)
...tersConfigModal/FiltersConfigForm/DefaultValue.tsx 20.83% <0.00%> (-4.17%) ⬇️
...nfigModal/FiltersConfigForm/getControlItemsMap.tsx 91.89% <ø> (ø)
...nd/src/dashboard/components/nativeFilters/utils.ts 56.25% <ø> (ø)
... and 58 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c7c6375...ad28c15. Read the comment docs.

Copy link

@graceguo-supercat graceguo-supercat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zhaoyongjie zhaoyongjie merged commit 352656a into apache:master Jun 24, 2021
@m-ajay m-ajay deleted the fix/filter-losing-focus branch June 25, 2021 13:46
cccs-RyanS pushed a commit to CybercentreCanada/superset that referenced this pull request Dec 17, 2021
QAlexBall pushed a commit to QAlexBall/superset that referenced this pull request Dec 29, 2021
cccs-rc pushed a commit to CybercentreCanada/superset that referenced this pull request Mar 6, 2024
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 1.3.0 labels Mar 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/XS 🚢 1.3.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants