Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(native-filters): show default text on filter scoping tree #15351

Merged
merged 1 commit into from
Jun 24, 2021

Conversation

villebro
Copy link
Member

@villebro villebro commented Jun 24, 2021

SUMMARY

Currently the filter scoping tree is showing titles that are not in line with those displayed on the dashboard. This PR changes the scoping tree to show the defaultTitle if a real title hasn't been given, similar to how the dashboard layout is rendered.

AFTER

image

BEFORE

image

TESTING INSTRUCTIONS

Updated test mock to reflect a use case where the tab's text isn't provided.

ADDITIONAL INFORMATION

@codecov
Copy link

codecov bot commented Jun 24, 2021

Codecov Report

Merging #15351 (43e4d60) into master (352656a) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #15351   +/-   ##
=======================================
  Coverage   77.16%   77.16%           
=======================================
  Files         973      973           
  Lines       50523    50524    +1     
  Branches     6184     6185    +1     
=======================================
+ Hits        38986    38987    +1     
  Misses      11331    11331           
  Partials      206      206           
Flag Coverage Δ
javascript 71.76% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...ConfigModal/FiltersConfigForm/FilterScope/utils.ts 98.52% <100.00%> (+0.02%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 352656a...43e4d60. Read the comment docs.

Copy link
Member

@kgabryje kgabryje left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@villebro villebro merged commit b3cdff4 into apache:master Jun 24, 2021
@villebro villebro deleted the villebro/scope-text branch June 24, 2021 08:01
cccs-RyanS pushed a commit to CybercentreCanada/superset that referenced this pull request Dec 17, 2021
QAlexBall pushed a commit to QAlexBall/superset that referenced this pull request Dec 29, 2021
cccs-rc pushed a commit to CybercentreCanada/superset that referenced this pull request Mar 6, 2024
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 1.3.0 labels Mar 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels preset-io size/XS 🚢 1.3.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[native-filters]scoping section shows uuid when dashboard with tabs shared the same name
3 participants