refactor(annotation): improve annotation modal

[stephenLYZ]

SUMMARY

• remove no sense status isHidden
• fix the bug that the modal data will be cleared when the modal is opened again
• add create/update toast to give a better feedback

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

before

2021-06-24.5.20.49.mov

after

2021-06-24.5.22.21.mov

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

• Has associated issue: [annotation] click on the edit button two times, the current preferences of the annotation layer disappear. #15205
• Changes UI
• Includes DB Migration (follow approval process in SIP-59)
  • Migration is atomic, supports rollback & is backwards-compatible
  • Confirm DB migration upgrade and downgrade tested
  • Runtime estimates and downtime expectations provided
• Introduces new feature or API
• Removes existing feature or API

[codecov]

Codecov Report

Merging #15359 (bd9a9a0) into master (352656a) will increase coverage by 0.00%.
The diff coverage is 81.91%.

❗ Current head bd9a9a0 differs from pull request most recent head 4dc29ed. Consider uploading reports for the commit 4dc29ed to get more accurate results

@@           Coverage Diff           @@
##           master   #15359   +/-   ##
=======================================
  Coverage   77.16%   77.17%           
=======================================
  Files         973      975    +2     
  Lines       50523    50583   +60     
  Branches     6184     6202   +18     
=======================================
+ Hits        38986    39035   +49     
- Misses      11331    11341   +10     
- Partials      206      207    +1     

Flag	Coverage Δ
javascript	71.77% <81.81%> (+0.01%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
...nd/src/common/hooks/useComponentDidUpdate/index.ts	0.00% <0.00%> (ø)
...ilterScopingModal/CrossFilterScopingForm/index.tsx	84.61% <ø> (ø)
...ntend/src/views/CRUD/annotation/AnnotationList.tsx	76.92% <ø> (ø)
...tend/src/views/CRUD/annotation/AnnotationModal.tsx	60.74% <14.28%> (-2.23%)	⬇️
...ConfigModal/FiltersConfigForm/FilterScope/state.ts	95.65% <66.66%> (-4.35%)	⬇️
superset/viz.py	56.52% <66.66%> (+0.05%)	⬆️
...odal/FiltersConfigForm/FilterScope/ScopingTree.tsx	90.62% <80.00%> (-5.03%)	⬇️
...ConfigModal/FiltersConfigForm/FilterScope/utils.ts	95.94% <83.33%> (-2.57%)	⬇️
...onfigModal/FiltersConfigForm/FiltersConfigForm.tsx	69.97% <90.90%> (+0.85%)	⬆️
...odal/FiltersConfigForm/FilterScope/FilterScope.tsx	88.88% <92.00%> (+2.68%)	⬆️
... and 5 more

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 352656a...4dc29ed. Read the comment docs.

[rusackas]

/testenv up

[github-actions]

@rusackas Ephemeral environment spinning up at http://54.188.214.198:8080. Credentials are admin/admin. Please allow several minutes for bootstrapping and startup.

[lilykuang]

manually tested. LGTM 👍

[github-actions]

Ephemeral environment shutdown and build artifacts deleted.