feat(native-filters): Hide non-numeric columns in numeric range filter #15385
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
villebro
reviewed
Jun 25, 2021
| @@ -103,6 +128,7 @@ export function ColumnSelect({ | |||
| onChange={onChange} | |||
| options={options} | |||
| placeholder={t('Select a column')} | |||
| notFoundContent={t('No columns found')} | |||
There was a problem hiding this comment.
Should we make this message display the currentFilterType when set, just in case? Something like "No numerical columns found" if filtering for numerical columns etc.
There was a problem hiding this comment.
Replaced with No compatible columns found, adding currentFilterType would require an ugly name mapping
|
|
||
| const FILTERS_FIELD_NAME = 'filters'; | ||
|
|
||
| export const FILTER_GROUPS = { | ||
| TIME: ['filter_time', 'filter_timegrain', 'filter_timecolumn'], |
There was a problem hiding this comment.
nit: would TEMPORAL be more accurate? Also, would it be a good idea to list the supported datatypes instead?
{
filter_time: [GenericDataType.TEMPORAL],
filter_timegrain: [GenericDataType.TEMPORAL],
filter_timecolumn: [GenericDataType.TEMPORAL],
filter_select: [GenericDataType.STRING, GenericDataType.NUMERIC, GenericDataType.TEMPORAL],
filter_range: [GenericDataType.NUMERIC],
}or similar.
edit: long-term this info should be moved into the plugin metadata
There was a problem hiding this comment.
Fantastic suggestion, thank you!
Codecov Report
@@ Coverage Diff @@
## master #15385 +/- ##
==========================================
- Coverage 77.26% 77.10% -0.17%
==========================================
Files 975 975
Lines 50579 50610 +31
Branches 6204 6212 +8
==========================================
- Hits 39081 39021 -60
- Misses 11291 11382 +91
Partials 207 207
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
michael-s-molina
approved these changes
Jun 25, 2021
| .filter(filterValues) | ||
| .map((col: Column) => col.column_name) | ||
| .sort((a: string, b: string) => a.localeCompare(b)) | ||
| .map((column: any) => ({ label: column, value: column })), |
There was a problem hiding this comment.
Suggested change
| .map((column: any) => ({ label: column, value: column })), | |
| .map((column: string) => ({ label: column, value: column })), |
mvoitko
pushed a commit
to mvoitko/superset
that referenced
this pull request
Jun 28, 2021
apache#15385) * feat(native-filters): Hide non-numeric columns in numeric range filter * Return true if type_generic undefined * Code review comments * Replace any with string * fix tests * add missing columns to select Co-authored-by: Ville Brofeldt <ville.v.brofeldt@gmail.com>
cccs-RyanS
pushed a commit
to CybercentreCanada/superset
that referenced
this pull request
Dec 17, 2021
apache#15385) * feat(native-filters): Hide non-numeric columns in numeric range filter * Return true if type_generic undefined * Code review comments * Replace any with string * fix tests * add missing columns to select Co-authored-by: Ville Brofeldt <ville.v.brofeldt@gmail.com>
QAlexBall
pushed a commit
to QAlexBall/superset
that referenced
this pull request
Dec 29, 2021
apache#15385) * feat(native-filters): Hide non-numeric columns in numeric range filter * Return true if type_generic undefined * Code review comments * Replace any with string * fix tests * add missing columns to select Co-authored-by: Ville Brofeldt <ville.v.brofeldt@gmail.com>
cccs-rc
pushed a commit
to CybercentreCanada/superset
that referenced
this pull request
Mar 6, 2024
apache#15385) * feat(native-filters): Hide non-numeric columns in numeric range filter * Return true if type_generic undefined * Code review comments * Replace any with string * fix tests * add missing columns to select Co-authored-by: Ville Brofeldt <ville.v.brofeldt@gmail.com>
mistercrunch
added
🏷️ bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
When user selects "Numerical range" native filter, only numeric columns should be available to choose. If there are no numeric columns in the dataset, show "No columns found" message in select column dropdown. When user has selected a non-numeric column and then changes filter type to numerical range, the column field should be reset.
We use
type_genericfield to check column's type. If a column doesn't havetype_genericfield, we assume that it's numeric as a failsafe.Thank you @dpgaspar and @villebro for providing the backend code!
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
Screen.Recording.2021-06-25.at.12.21.23.mov
TESTING INSTRUCTIONS
DASHBOARD_NATIVE_FILTERSfeature flagmessage_channels, have columns withtype_genericfield unset. In those cases, we display them as a failsafe)ADDITIONAL INFORMATION