Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: Removed jsx-remove-data-test-id usage from code for multi-build-variant testing #15386

Conversation

adam-stasiak
Copy link
Contributor

SUMMARY

I disabled babel option to remove data-test from non-development builds.

Thanks to this change it would be possible to easier write any kind of black box e2e tests for non-dev deployments.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

before:
image

after:
image

TESTING INSTRUCTIONS

  1. Build application as non-dev (npm run build)
  2. Access page
  3. In Chrome inspector check whether data-test attributes are in code.

ADDITIONAL INFORMATION

  • Has associated issue:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@adam-stasiak adam-stasiak changed the title Removed jsx-remove-data-test-id usage from code for multi-build-variant testing [build] Removed jsx-remove-data-test-id usage from code for multi-build-variant testing Jun 25, 2021
@adam-stasiak adam-stasiak reopened this Jun 25, 2021
@adam-stasiak adam-stasiak changed the title [build] Removed jsx-remove-data-test-id usage from code for multi-build-variant testing build: Removed jsx-remove-data-test-id usage from code for multi-build-variant testing Jun 25, 2021
@adam-stasiak adam-stasiak reopened this Jun 25, 2021
@codecov
Copy link

codecov bot commented Jun 25, 2021

Codecov Report

Merging #15386 (b61df43) into master (45c3ae0) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #15386   +/-   ##
=======================================
  Coverage   77.07%   77.07%           
=======================================
  Files         983      983           
  Lines       51618    51618           
  Branches     6991     6991           
=======================================
  Hits        39785    39785           
  Misses      11608    11608           
  Partials      225      225           
Flag Coverage Δ
javascript 71.69% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 45c3ae0...b61df43. Read the comment docs.

@adam-stasiak adam-stasiak reopened this Jun 25, 2021
@adam-stasiak adam-stasiak reopened this Jun 28, 2021
@rusackas rusackas added this to To do in Preset-QA Jun 28, 2021
@adam-stasiak
Copy link
Contributor Author

@rusackas Can we proceed with this change?

@adam-stasiak adam-stasiak force-pushed the disabled-test-id-cleanup-in-production-code branch from 04a03b8 to 5f6e65f Compare July 19, 2021 12:34
@adam-stasiak
Copy link
Contributor Author

@rusackas I added an option to force different configuration from command line and added extra babel configuration which does not use trimming if someone wants to build production but without this plugin.

@rusackas rusackas removed the Polidea label Aug 1, 2021
@rusackas rusackas merged commit 578a9e9 into apache:master Aug 9, 2021
opus-42 pushed a commit to opus-42/incubator-superset that referenced this pull request Nov 14, 2021
…d-variant testing (apache#15386)

* enabled customized production build with testIds

* fix for docker

* changed substitution

* changed substitution
QAlexBall pushed a commit to QAlexBall/superset that referenced this pull request Dec 28, 2021
…d-variant testing (apache#15386)

* enabled customized production build with testIds

* fix for docker

* changed substitution

* changed substitution
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 1.4.0 labels Mar 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels preset:QA Preset QA team size/S 🚢 1.4.0
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

None yet

3 participants