New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Cascading filter popover widens automatically #15390
fix: Cascading filter popover widens automatically #15390
Conversation
Codecov Report
@@ Coverage Diff @@
## master #15390 +/- ##
==========================================
+ Coverage 76.78% 77.15% +0.36%
==========================================
Files 975 975
Lines 50550 50650 +100
Branches 6204 6223 +19
==========================================
+ Hits 38817 39080 +263
+ Misses 11526 11359 -167
- Partials 207 211 +4
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the fix! One comment about the added caret. Also, we should probably have a quick discussion about whether or not we want to remove the indentation. I understand that the original design removes valuable horizontal real estate that can cause trouble if there are deeply nested filter, but it would be good to hear other people's thoughts on how to best relay information about the cascading hierarchy.
...c/dashboard/components/nativeFilters/FilterBar/CascadeFilters/CascadeFilterControl/index.tsx
Outdated
Show resolved
Hide resolved
da35ed7
to
8d922c4
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍 Let's try to squeeze in an engineering+design session at some point to refine the cascading functionality (deep nesting vs current shallow nesting) + design (popover, indentation etc)
(cherry picked from commit ac18c90)
SUMMARY
Fixes #15354
@rusackas @villebro
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
TESTING INSTRUCTIONS
Check the original issue for instructions.
ADDITIONAL INFORMATION