Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Cascading filter popover widens automatically #15390

Merged

Conversation

michael-s-molina
Copy link
Member

@michael-s-molina michael-s-molina commented Jun 25, 2021

SUMMARY

Fixes #15354

@rusackas @villebro

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

Screen Shot 2021-06-25 at 2 22 35 PM

Screen Shot 2021-06-28 at 8 36 31 AM

TESTING INSTRUCTIONS

Check the original issue for instructions.

ADDITIONAL INFORMATION

  • Has associated issue:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@michael-s-molina michael-s-molina added this to In progress in Native dashboard filters via automation Jun 25, 2021
@michael-s-molina michael-s-molina self-assigned this Jun 25, 2021
@codecov
Copy link

codecov bot commented Jun 25, 2021

Codecov Report

Merging #15390 (f4875d1) into master (95b9e2e) will increase coverage by 0.36%.
The diff coverage is 43.43%.

❗ Current head f4875d1 differs from pull request most recent head 8d922c4. Consider uploading reports for the commit 8d922c4 to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master   #15390      +/-   ##
==========================================
+ Coverage   76.78%   77.15%   +0.36%     
==========================================
  Files         975      975              
  Lines       50550    50650     +100     
  Branches     6204     6223      +19     
==========================================
+ Hits        38817    39080     +263     
+ Misses      11526    11359     -167     
- Partials      207      211       +4     
Flag Coverage Δ
javascript 71.73% <36.62%> (-0.08%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...rset-frontend/src/components/ImportModal/index.tsx 69.89% <ø> (+0.10%) ⬆️
superset-frontend/src/components/Select/Select.tsx 0.00% <0.00%> (ø)
...src/dashboard/components/DashboardBuilder/utils.ts 84.61% <0.00%> (+6.04%) ⬆️
...src/dashboard/components/PropertiesModal/index.jsx 85.61% <ø> (ø)
...src/dashboard/components/gridComponents/Column.jsx 87.87% <ø> (ø)
...nd/src/dashboard/components/gridComponents/Row.jsx 86.66% <ø> (ø)
...ers/components/TimeGrain/TimeGrainFilterPlugin.tsx 0.00% <0.00%> (ø)
.../FilterBar/CascadeFilters/CascadePopover/index.tsx 62.31% <33.33%> (+0.55%) ⬆️
...d/src/explore/components/DatasourcePanel/index.tsx 81.33% <57.14%> (-9.74%) ⬇️
superset/app.py 68.42% <63.41%> (-14.92%) ⬇️
... and 53 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 95b9e2e...8d922c4. Read the comment docs.

Copy link
Member

@villebro villebro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix! One comment about the added caret. Also, we should probably have a quick discussion about whether or not we want to remove the indentation. I understand that the original design removes valuable horizontal real estate that can cause trouble if there are deeply nested filter, but it would be good to hear other people's thoughts on how to best relay information about the cascading hierarchy.

Copy link
Member

@villebro villebro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍 Let's try to squeeze in an engineering+design session at some point to refine the cascading functionality (deep nesting vs current shallow nesting) + design (popover, indentation etc)

@villebro villebro moved this from In progress to In review in Native dashboard filters Jun 28, 2021
@amitmiran137 amitmiran137 merged commit ac18c90 into apache:master Jun 28, 2021
Native dashboard filters automation moved this from In review to Done Jun 28, 2021
amitmiran137 pushed a commit that referenced this pull request Jul 4, 2021
cccs-RyanS pushed a commit to CybercentreCanada/superset that referenced this pull request Dec 17, 2021
QAlexBall pushed a commit to QAlexBall/superset that referenced this pull request Dec 29, 2021
cccs-rc pushed a commit to CybercentreCanada/superset that referenced this pull request Mar 6, 2024
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 1.3.0 labels Mar 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/M v1.3 🚢 1.3.0
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

[native-filters] cascading filter popover widens automatically
4 participants