Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: icon to icons for inderteminatecheckbox icon #15397

Merged
merged 4 commits into from Jun 29, 2021

Conversation

pkdotson
Copy link
Member

SUMMARY

this pr refactors the indeterminatecheckbox icon to icons.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

before
Screen Shot 2021-06-25 at 1 58 30 PM
Screen Shot 2021-06-25 at 1 58 25 PM

after
Screen Shot 2021-06-25 at 11 10 12 AM
Screen Shot 2021-06-25 at 11 10 04 AM

TESTING INSTRUCTIONS

Go to the listviews and test out on the bulk select feature.

ADDITIONAL INFORMATION

  • Has associated issue:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@pkdotson pkdotson changed the title refactor: icon to icons for inderterminatecheckbox icon refactor: icon to icons for inderteminatecheckbox icon Jun 25, 2021
@codecov
Copy link

codecov bot commented Jun 25, 2021

Codecov Report

Merging #15397 (0511e9e) into master (a7e1037) will decrease coverage by 0.02%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #15397      +/-   ##
==========================================
- Coverage   77.23%   77.21%   -0.03%     
==========================================
  Files         975      975              
  Lines       50595    50642      +47     
  Branches     6204     6228      +24     
==========================================
+ Hits        39079    39102      +23     
- Misses      11309    11329      +20     
- Partials      207      211       +4     
Flag Coverage Δ
javascript 71.71% <100.00%> (-0.05%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...end/src/components/IndeterminateCheckbox/index.tsx 100.00% <100.00%> (ø)
...d/src/explore/components/DatasourcePanel/index.tsx 81.33% <0.00%> (-9.74%) ⬇️
...rBar/CascadeFilters/CascadeFilterControl/index.tsx 90.00% <0.00%> (-2.31%) ⬇️
...tersConfigModal/FiltersConfigForm/ColumnSelect.tsx 95.91% <0.00%> (-1.46%) ⬇️
...ters/FiltersConfigModal/FiltersConfigForm/utils.ts 92.30% <0.00%> (-1.45%) ⬇️
...onfigModal/FiltersConfigForm/FiltersConfigForm.tsx 69.52% <0.00%> (-0.65%) ⬇️
superset-frontend/src/components/Select/Select.tsx 0.00% <0.00%> (ø)
...src/dashboard/components/DeleteComponentButton.jsx 100.00% <0.00%> (ø)
...src/dashboard/components/PropertiesModal/index.jsx 85.61% <0.00%> (ø)
...src/dashboard/components/gridComponents/Column.jsx 87.87% <0.00%> (ø)
... and 9 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a7e1037...0511e9e. Read the comment docs.

Copy link
Member

@michael-s-molina michael-s-molina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Currently, the checkboxes are using the base primary color.

pkdotson and others added 2 commits June 28, 2021 11:54
Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com>
@rusackas
Copy link
Member

/testenv up

@github-actions
Copy link
Contributor

@rusackas Ephemeral environment spinning up at http://54.190.22.91:8080. Credentials are admin/admin. Please allow several minutes for bootstrapping and startup.

@pkdotson pkdotson merged commit a0179ac into apache:master Jun 29, 2021
@github-actions
Copy link
Contributor

Ephemeral environment shutdown and build artifacts deleted.

cccs-RyanS pushed a commit to CybercentreCanada/superset that referenced this pull request Dec 17, 2021
* initial commit

* fix cypress tests

* Update superset-frontend/src/components/IndeterminateCheckbox/index.tsx

Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com>

* Update index.tsx

Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com>
QAlexBall pushed a commit to QAlexBall/superset that referenced this pull request Dec 29, 2021
* initial commit

* fix cypress tests

* Update superset-frontend/src/components/IndeterminateCheckbox/index.tsx

Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com>

* Update index.tsx

Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com>
cccs-rc pushed a commit to CybercentreCanada/superset that referenced this pull request Mar 6, 2024
* initial commit

* fix cypress tests

* Update superset-frontend/src/components/IndeterminateCheckbox/index.tsx

Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com>

* Update index.tsx

Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com>
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 1.3.0 labels Mar 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels preset-io size/M 🚢 1.3.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants