New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: icon to icons for inderteminatecheckbox icon #15397
Conversation
Codecov Report
@@ Coverage Diff @@
## master #15397 +/- ##
==========================================
- Coverage 77.23% 77.21% -0.03%
==========================================
Files 975 975
Lines 50595 50642 +47
Branches 6204 6228 +24
==========================================
+ Hits 39079 39102 +23
- Misses 11309 11329 +20
- Partials 207 211 +4
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Currently, the checkboxes are using the base primary color.
superset-frontend/src/components/IndeterminateCheckbox/index.tsx
Outdated
Show resolved
Hide resolved
superset-frontend/src/components/IndeterminateCheckbox/index.tsx
Outdated
Show resolved
Hide resolved
Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com>
/testenv up |
@rusackas Ephemeral environment spinning up at http://54.190.22.91:8080. Credentials are |
Ephemeral environment shutdown and build artifacts deleted. |
* initial commit * fix cypress tests * Update superset-frontend/src/components/IndeterminateCheckbox/index.tsx Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com> * Update index.tsx Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com>
* initial commit * fix cypress tests * Update superset-frontend/src/components/IndeterminateCheckbox/index.tsx Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com> * Update index.tsx Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com>
* initial commit * fix cypress tests * Update superset-frontend/src/components/IndeterminateCheckbox/index.tsx Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com> * Update index.tsx Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com>
SUMMARY
this pr refactors the indeterminatecheckbox icon to icons.
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
before
after
TESTING INSTRUCTIONS
Go to the listviews and test out on the bulk select feature.
ADDITIONAL INFORMATION