-
Notifications
You must be signed in to change notification settings - Fork 13.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: icon to icons for infotooltip component #15398
Conversation
Codecov Report
@@ Coverage Diff @@
## master #15398 +/- ##
==========================================
- Coverage 77.23% 77.23% -0.01%
==========================================
Files 975 974 -1
Lines 50595 50726 +131
Branches 6204 6256 +52
==========================================
+ Hits 39079 39180 +101
- Misses 11309 11333 +24
- Partials 207 213 +6
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
Can you fix the vertical alignment of the checkbox, text, and icon? |
Yep fixed and updated in new after photo |
The |
/testenv up |
@michael-s-molina Ephemeral environment spinning up at http://54.202.9.156:8080. Credentials are |
Ephemeral environment shutdown and build artifacts deleted. |
* intital commit * align label texts and icons * fix style
* intital commit * align label texts and icons * fix style
* intital commit * align label texts and icons * fix style
SUMMARY
this pr refactors the infotooltip component from icons to icon
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
before
![Expose in SQL Lab 6](https://user-images.githubusercontent.com/17326228/123527997-e9c05080-d698-11eb-9c7c-64910325ca75.png)
after
![Screen Shot 2021-06-29 at 4 15 47 PM](https://user-images.githubusercontent.com/17326228/123879152-4d46ba00-d8f5-11eb-94a2-8931bbac2296.png)
TESTING INSTRUCTIONS
got to database modal to verify infotooltip icon
ADDITIONAL INFORMATION