Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: double click slq lab table cell #15400

Merged

Conversation

graceguo-supercat
Copy link

@graceguo-supercat graceguo-supercat commented Jun 27, 2021

SUMMARY

To reproduce this issue:

  1. open sql lab, run a simple search: select * from wb_health_population
  2. double click any cell in the first column: the highlight spread out to many other cells
  3. paste the selected text: it has text in many other columns

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

Before:
ar7FekcDi5

After:
f6s0Y3PU0d

TESTING INSTRUCTIONS

CI and manual test

@codecov
Copy link

codecov bot commented Jun 27, 2021

Codecov Report

Merging #15400 (e768973) into master (22d23fc) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #15400   +/-   ##
=======================================
  Coverage   77.23%   77.23%           
=======================================
  Files         975      975           
  Lines       50592    50592           
  Branches     6204     6204           
=======================================
  Hits        39075    39075           
  Misses      11310    11310           
  Partials      207      207           
Flag Coverage Δ
javascript 71.75% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...src/components/FilterableTable/FilterableTable.tsx 82.26% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 22d23fc...e768973. Read the comment docs.

Copy link
Member

@amitmiran137 amitmiran137 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@amitmiran137 amitmiran137 merged commit 1c4cb28 into apache:master Jun 28, 2021
cccs-RyanS pushed a commit to CybercentreCanada/superset that referenced this pull request Dec 17, 2021
QAlexBall pushed a commit to QAlexBall/superset that referenced this pull request Dec 29, 2021
cccs-rc pushed a commit to CybercentreCanada/superset that referenced this pull request Mar 6, 2024
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 1.3.0 labels Mar 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/XS 🚢 1.3.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants