Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: icon to icons for lastupdated component #15401

Merged
merged 3 commits into from Jun 29, 2021

Conversation

pkdotson
Copy link
Member

SUMMARY

This pr updates the lastupdated component

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

before
Reports

after
Reports

TESTING INSTRUCTIONS

go to alerts and reports to view the lastupdated component

ADDITIONAL INFORMATION

  • Has associated issue:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@codecov
Copy link

codecov bot commented Jun 27, 2021

Codecov Report

Merging #15401 (2536d09) into master (22d23fc) will decrease coverage by 0.02%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #15401      +/-   ##
==========================================
- Coverage   77.23%   77.20%   -0.03%     
==========================================
  Files         975      975              
  Lines       50592    50638      +46     
  Branches     6204     6228      +24     
==========================================
+ Hits        39075    39096      +21     
- Misses      11310    11331      +21     
- Partials      207      211       +4     
Flag Coverage Δ
javascript 71.70% <100.00%> (-0.05%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...rset-frontend/src/components/LastUpdated/index.tsx 96.00% <100.00%> (ø)
...d/src/explore/components/DatasourcePanel/index.tsx 81.33% <0.00%> (-9.74%) ⬇️
...rBar/CascadeFilters/CascadeFilterControl/index.tsx 90.00% <0.00%> (-2.31%) ⬇️
...tersConfigModal/FiltersConfigForm/ColumnSelect.tsx 95.91% <0.00%> (-1.46%) ⬇️
...ters/FiltersConfigModal/FiltersConfigForm/utils.ts 92.30% <0.00%> (-1.45%) ⬇️
...onfigModal/FiltersConfigForm/FiltersConfigForm.tsx 69.52% <0.00%> (-0.65%) ⬇️
superset-frontend/src/components/Select/Select.tsx 0.00% <0.00%> (ø)
...ers/components/TimeGrain/TimeGrainFilterPlugin.tsx 0.00% <0.00%> (ø)
...Filters/FilterBar/FilterControls/FilterControl.tsx 100.00% <0.00%> (ø)
.../FilterBar/CascadeFilters/CascadePopover/index.tsx 62.31% <0.00%> (+0.55%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 22d23fc...2536d09. Read the comment docs.

Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com>
@pkdotson pkdotson merged commit 076f774 into apache:master Jun 29, 2021
cccs-RyanS pushed a commit to CybercentreCanada/superset that referenced this pull request Dec 17, 2021
* intial commit

* fix test

* Update superset-frontend/src/components/LastUpdated/index.tsx

Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com>

Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com>
QAlexBall pushed a commit to QAlexBall/superset that referenced this pull request Dec 29, 2021
* intial commit

* fix test

* Update superset-frontend/src/components/LastUpdated/index.tsx

Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com>

Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com>
cccs-rc pushed a commit to CybercentreCanada/superset that referenced this pull request Mar 6, 2024
* intial commit

* fix test

* Update superset-frontend/src/components/LastUpdated/index.tsx

Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com>

Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com>
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 1.3.0 labels Mar 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels preset-io size/S 🚢 1.3.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants