refactor: icon to icons for listviewcomponent

[pkdotson]

SUMMARY

this pr refactors the listview icon and and cardview icon to the new icons component

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

before

after

TESTING INSTRUCTIONS

got to any of the listviews to view card and list icons

ADDITIONAL INFORMATION

• Has associated issue:
• Changes UI
• Includes DB Migration (follow approval process in SIP-59)
  • Migration is atomic, supports rollback & is backwards-compatible
  • Confirm DB migration upgrade and downgrade tested
  • Runtime estimates and downtime expectations provided
• Introduces new feature or API
• Removes existing feature or API

[codecov]

Codecov Report

Merging #15408 (99674c6) into master (09c44d0) will decrease coverage by 0.10%.
The diff coverage is 62.73%.

❗ Current head 99674c6 differs from pull request most recent head 26cb774. Consider uploading reports for the commit 26cb774 to get more accurate results

@@            Coverage Diff             @@
##           master   #15408      +/-   ##
==========================================
- Coverage   77.23%   77.12%   -0.11%     
==========================================
  Files         975      974       -1     
  Lines       50610    50817     +207     
  Branches     6212     6727     +515     
==========================================
+ Hits        39090    39195     +105     
- Misses      11313    11407      +94     
- Partials      207      215       +8     

Flag	Coverage Δ
javascript	71.77% <65.53%> (+<0.01%)	⬆️
presto	?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
...erset-frontend/src/components/AnchorLink/index.jsx	95.83% <ø> (ø)
...rset-frontend/src/components/ErrorMessage/types.ts	100.00% <ø> (ø)
...src/components/FilterableTable/FilterableTable.tsx	82.26% <ø> (ø)
superset-frontend/src/components/Icons/index.tsx	100.00% <ø> (ø)
superset-frontend/src/components/Select/Select.tsx	0.00% <0.00%> (ø)
superset-frontend/src/constants.ts	100.00% <ø> (ø)
superset-frontend/src/dashboard/actions/hydrate.js	1.72% <ø> (ø)
...frontend/src/dashboard/components/Header/index.jsx	67.15% <ø> (ø)
...dashboard/components/SliceHeaderControls/index.tsx	76.98% <ø> (ø)
...c/dashboard/components/gridComponents/Markdown.jsx	82.82% <ø> (ø)
... and 55 more

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 09c44d0...26cb774. Read the comment docs.

[michael-s-molina]

/testenv up

[github-actions]

@michael-s-molina Ephemeral environment creation is currently limited to committers.

[michael-s-molina]

@michael-s-molina Ephemeral environment creation is currently limited to committers.

😢 @rusackas?

[rusackas]

/testenv up

[github-actions]

@rusackas Ephemeral environment spinning up at http://52.35.136.255:8080. Credentials are admin/admin. Please allow several minutes for bootstrapping and startup.

[michael-s-molina]

@pkdotson The alignment is a little bit up after the change. This problem is happening in more than one place when the new icon component is being used. Maybe we can find a global solution for this?

[michael-s-molina]

Another thing is that the icon is not centralized inside the button or the button should have more height.

[rusackas]

LGTM. Thanks for the alignment tweak.

[github-actions]

Ephemeral environment shutdown and build artifacts deleted.