Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add dashboard markdown id #15418

Merged
merged 1 commit into from Jun 29, 2021
Merged

Conversation

krsnik93
Copy link
Contributor

@krsnik93 krsnik93 commented Jun 28, 2021

SUMMARY

This PR adds html id's to dashboard markdown components. Fixes #15358. Added so that different css can be applied to each markdown, which I was not able to do previously.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

Before screenshots can be seen in #15358.

After screenshots:
image

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

  • Has associated issue: Add html id to markdown components #15358
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@codecov
Copy link

codecov bot commented Jun 28, 2021

Codecov Report

Merging #15418 (9f4fe6a) into master (f53b2c6) will decrease coverage by 0.22%.
The diff coverage is n/a.

❗ Current head 9f4fe6a differs from pull request most recent head 4d38b5f. Consider uploading reports for the commit 4d38b5f to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master   #15418      +/-   ##
==========================================
- Coverage   77.22%   76.99%   -0.23%     
==========================================
  Files         975      975              
  Lines       50634    50634              
  Branches     6222     6222              
==========================================
- Hits        39104    38988     -116     
- Misses      11319    11435     +116     
  Partials      211      211              
Flag Coverage Δ
hive ?
javascript 71.75% <ø> (ø)
presto ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...c/dashboard/components/gridComponents/Markdown.jsx 82.82% <ø> (ø)
superset/config.py 91.15% <ø> (ø)
superset/db_engines/hive.py 0.00% <0.00%> (-82.15%) ⬇️
superset/db_engine_specs/hive.py 69.20% <0.00%> (-17.21%) ⬇️
superset/db_engine_specs/presto.py 83.36% <0.00%> (-6.53%) ⬇️
superset/views/database/mixins.py 81.03% <0.00%> (-1.73%) ⬇️
superset/connectors/sqla/models.py 88.22% <0.00%> (-1.65%) ⬇️
superset/db_engine_specs/base.py 87.97% <0.00%> (-0.41%) ⬇️
superset/models/core.py 89.76% <0.00%> (-0.27%) ⬇️
superset/utils/core.py 88.97% <0.00%> (-0.13%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f53b2c6...4d38b5f. Read the comment docs.

@krsnik93
Copy link
Contributor Author

@suddjian I made a small change - decided to drop the redundant dashboard-markdown- prefix after reading up on the way IDs are created. Sorry about that.
image

@amitmiran137 amitmiran137 merged commit b8f4e7d into apache:master Jun 29, 2021
@krsnik93 krsnik93 deleted the add-id-to-markdown branch June 29, 2021 09:42
amitmiran137 pushed a commit that referenced this pull request Jul 4, 2021
Co-authored-by: root <root@src4.ikrsnik.devonly.net>
(cherry picked from commit b8f4e7d)
cccs-RyanS pushed a commit to CybercentreCanada/superset that referenced this pull request Dec 17, 2021
Co-authored-by: root <root@src4.ikrsnik.devonly.net>
QAlexBall pushed a commit to QAlexBall/superset that referenced this pull request Dec 29, 2021
Co-authored-by: root <root@src4.ikrsnik.devonly.net>
cccs-rc pushed a commit to CybercentreCanada/superset that referenced this pull request Mar 6, 2024
Co-authored-by: root <root@src4.ikrsnik.devonly.net>
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 1.3.0 labels Mar 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/XS v1.3 🚢 1.3.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add html id to markdown components
4 participants